antrea icon indicating copy to clipboard operation
antrea copied to clipboard

Published 20 hours ago • verified publisher icon antrea-io

Improve "antctl mc" usage

Open antoninbas opened this issue 1 year ago • 8 comments

When I used the wrong Antrea version tag by mistake, I got the following error:

antctl mc deploy leadercluster -n antrea-multicluster --antrea-version 1.15.0
Error: json: cannot unmarshal string into Go value of type unstructured.detector

The error is because the tag should b v1.15.0 instead of 1.15.0.

It would be good IMO if the v was optional (i.e., we could support both formats). And it would also be good to have a better error message if someone provides an invalid tag or a tag that doesn't exist.

cc @luolanzone

antoninbas avatar Mar 26 '24 21:03 antoninbas

@hjiajing

luolanzone avatar Mar 27 '24 01:03 luolanzone

@hjiajing

Thanks for the reminder, I will check and fix this.

hjiajing avatar Mar 27 '24 02:03 hjiajing

can I work on this issue?

EraKin575 avatar Mar 30 '24 09:03 EraKin575

@EraKin575, @hjiajing may be working on this already. If not, you are welcome to submit a PR.

antoninbas avatar Apr 01 '24 18:04 antoninbas

Hi @antoninbas , I have not worked on this yet, maybe @EraKin575 could do it.

hjiajing avatar Apr 02 '24 02:04 hjiajing

@EraKin575 feel free to submit a PR for this

antoninbas avatar Apr 02 '24 18:04 antoninbas

Hi @EraKin575 are you still actively working on this issue?

luolanzone avatar Apr 30 '24 02:04 luolanzone

Hi @luolanzone! I am working on this issue and will try to raise a PR by today.

roopeshsn avatar May 01 '24 02:05 roopeshsn

Fixed by #6287

antoninbas avatar May 22 '24 02:05 antoninbas