antrea
antrea copied to clipboard
Replace github.com/TomCodeLV/OVSDB-golang-lib with github.com/ovn-org/libovsdb
https://github.com/TomCodeLV/OVSDB-golang-lib is not actively maintained
while it works well for us at the moment, we could consider replacing it with https://github.com/ovn-org/libovsdb which is actively maintained and used in ovn-kubernetes
@antoninbas, will fix it can you assign it to me
Thanks for your interest. You are welcome to take a stab at this and I can assign you.
Thanks for your interest. You are welcome to take a stab at this and I can assign you.
hey @antoninbas, thank you
hey @antoninbas, where do u seek to put the replacements
@prakrit55 I am not sure I understand the question.
This issue is about replacing one dependency which is no longer maintainer with another dependency which is actively maintained. When performing the replacement, the Antrea code using this dependency will need to be updated. I do not expect any significant code relocation. Some new code may be required, in which case it is likely to go under pkg/ovs/ovsconfig/
, which is where the dependency is being used.
If you have follow up questions, it's probably better to chat in Slack.
hey @antoninbas, how do u seek to put it https://github.com/ovn-org/libovsdb/blob/03f787b1a8922c112936f4f4d1d75db04967d1be/database/transaction/transaction.go#L27 like
https://github.com/TomCodeLV/OVSDB-golang-lib/blob/9bbdfadcd88184cc76e4e4a589d45cebcf0a66bc/pkg/ovsdb/client.go#L488
for transaction
over here https://github.com/antrea-io/antrea/blob/e6a961292be22c8c6e6ee5c90b4ed882cdcc9143/pkg/ovs/ovsconfig/ovs_client.go#L173
Hi, if this issue is inactive, can I try it?
This issue has been assigned to @prakrit55 recently, so unless we don't hear from him for a while, it's probably better not to duplicate efforts.
But @prakrit55, if you stop working on this, please let us know and unassign yourself.
hey @AbhishekTiwari23, sure thing you can check this out, some code changes too needed to be done and there are multiple files you may have to check on 🙂
hey @AbhishekTiwari23 are you currently working on this?
@aroradaman I think you can take a stab at this if you want, I have not seen any recent activity from @AbhishekTiwari23
This issue is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days
Hi @antoninbas, I have started working on this issue.