antrea icon indicating copy to clipboard operation
antrea copied to clipboard

Replace deprecated bincover with golang built-in coverage profiling tool

Open luolanzone opened this issue 1 year ago • 13 comments

Describe what you are trying to solve @antoninbas reported that https://github.com/confluentinc/bincover is deprecated:

the bincover (https://github.com/confluentinc/bincover) project that we have been using for a couple of years to collect code 
coverage information when running unit tests has been deprecated. This is because starting with Go 1.20 (we still use Go 1.19 in 
Antrea, and we are waiting for Go 1.21, as we usually skip a version) there is a native way of doing the same thing: https://go.dev/testing/coverage/

Describe the solution you have in mind We should use built-in Go coverage profiling tool https://go.dev/testing/coverage/ to replace the deprecated one once golang 1.21 is released and Antrea is upgraded to it.

luolanzone avatar May 11 '23 02:05 luolanzone

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days

github-actions[bot] avatar Aug 10 '23 00:08 github-actions[bot]

@luolanzone @ceclinux now that we are officially using Go v1.21, we can make progress on this issue. It will be good to take care of this, remove the bincover dependency, and hopefully simplify code coverage measurement for e2e tests.

antoninbas avatar Aug 22 '23 19:08 antoninbas

@luolanzone @ceclinux now that we are officially using Go v1.21, we can make progress on this issue. It will be good to take care of this, remove the bincover dependency, and hopefully simplify code coverage measurement for e2e tests.

Sure.

ceclinux avatar Aug 23 '23 04:08 ceclinux

@luolanzone @ceclinux can we move forward with this issue in order to reduce tech debt?

antoninbas avatar Oct 25 '23 18:10 antoninbas

@luolanzone @ceclinux can we move forward with this issue in order to reduce tech debt?

I will take time to work on this, and it is expected to be finished in Antrea 1.16. Thanks.

ceclinux avatar Oct 26 '23 08:10 ceclinux

@luolanzone Can I give this a try? I have some experience with testing and code coverage collection.

VaibhavMalik4187 avatar Jan 23 '24 18:01 VaibhavMalik4187

We have submitted this issue as a project idea for the LFX mentorship program: https://github.com/cncf/mentoring/pull/1129. So no-one should ideally work on this issue until we know if the proposal is accepted and if we can match a mentee to work on it. See https://docs.linuxfoundation.org/lfx/mentorship for more information on the program.

antoninbas avatar Jan 23 '24 18:01 antoninbas

We have submitted this issue as a project idea for the LFX mentorship program: cncf/mentoring#1129. So no-one should ideally work on this issue until we know if the proposal is accepted and if we can match a mentee to work on it. See https://docs.linuxfoundation.org/lfx/mentorship for more information on the program.

Okay, thanks for the heads up.

VaibhavMalik4187 avatar Jan 23 '24 18:01 VaibhavMalik4187

This seems intuitive! Would love the opportunity to contribute.

dvjsharma avatar Feb 01 '24 05:02 dvjsharma

Hello! I'm considering applying to LFX for this project - looking forward to contribute! I'll poke around the good first issues so that I can get a better understanding of the code base before I apply to this project. Thanks!

anirudhprabhakaran3 avatar Feb 03 '24 01:02 anirudhprabhakaran3

Hi! I am considering applying to LFX mentorship for this project. I have some experience with code coverage and testing. I would love to explore more about Antrea and its vision and goals. Thanks!

EraKin575 avatar Feb 07 '24 09:02 EraKin575

For all the folks who have applied or are considering applying to one of the Antrea projects for the LFX mentorship program, we have published instructions to complete test tasks: https://github.com/antrea-io/antrea/discussions/5976. We will review your submissions for these tasks alongside other material (resume, cover letter) when selecting mentees. The deadline for submitting is February 20th 5PM PST.

antoninbas avatar Feb 09 '24 19:02 antoninbas

@shikharish will work on this as part of the LFX mentorship program

antoninbas avatar Mar 05 '24 00:03 antoninbas