antrea icon indicating copy to clipboard operation
antrea copied to clipboard

Add unit test for antctl get featuregates

Open luolanzone opened this issue 3 years ago • 1 comments
trafficstars

  1. Add unit test for antctl get featuregates command.
  2. Replace deprecated io/ioutil with os

Signed-off-by: Lan Luo [email protected]

luolanzone avatar Sep 29 '22 07:09 luolanzone

Codecov Report

Merging #4256 (f6e8c3e) into main (835e142) will decrease coverage by 0.36%. The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4256      +/-   ##
==========================================
- Coverage   64.38%   64.01%   -0.37%     
==========================================
  Files         393      397       +4     
  Lines       55538    56283     +745     
==========================================
+ Hits        35760    36032     +272     
- Misses      17188    17637     +449     
- Partials     2590     2614      +24     
Flag Coverage Δ
e2e-tests 38.95% <ø> (?)
integration-tests 34.53% <ø> (-0.08%) :arrow_down:
kind-e2e-tests 49.13% <ø> (+0.26%) :arrow_up:
unit-tests 48.34% <71.42%> (+0.18%) :arrow_up:
Impacted Files Coverage Δ
pkg/antctl/raw/proxy/command.go 23.52% <0.00%> (ø)
pkg/antctl/raw/supportbundle/command.go 3.40% <0.00%> (ø)
pkg/antctl/raw/featuregates/command.go 72.32% <75.00%> (+64.40%) :arrow_up:
pkg/features/antrea_features.go 41.02% <0.00%> (-18.98%) :arrow_down:
pkg/agent/secondarynetwork/podwatch/controller.go 61.69% <0.00%> (-13.13%) :arrow_down:
pkg/util/runtime/runtime_linux.go 76.00% <0.00%> (-8.00%) :arrow_down:
pkg/agent/util/sysctl/sysctl_linux.go 59.25% <0.00%> (-7.41%) :arrow_down:
...ntrollers/multicluster/serviceexport_controller.go 76.33% <0.00%> (-2.80%) :arrow_down:
pkg/agent/controller/networkpolicy/packetin.go 74.32% <0.00%> (-2.71%) :arrow_down:
pkg/controller/traceflow/controller.go 74.72% <0.00%> (-2.53%) :arrow_down:
... and 36 more

codecov[bot] avatar Sep 29 '22 07:09 codecov[bot]

@antoninbas @jianjuns @tnqn Could you help to review again? thanks.

luolanzone avatar Oct 21 '22 07:10 luolanzone

Seems there is no more review comments, @antoninbas could you help to merge this one? thanks.

luolanzone avatar Nov 04 '22 01:11 luolanzone

/test-e2e /skip-conformance /skip-networkpolicy

antoninbas avatar Nov 04 '22 17:11 antoninbas