antrea icon indicating copy to clipboard operation
antrea copied to clipboard

Update codecov.yml

Open wenqiq opened this issue 3 years ago • 3 comments

Update codecov.yml

  1. codecov bot comment after 5 builds.
  2. patch/status ensures the patch lines cov > 65%(ut and e2e/integration).
  3. project/status ensures the project ut cov not decrease.

Signed-off-by: Wenqi Qiu [email protected]

wenqiq avatar Sep 14 '22 13:09 wenqiq

Codecov Report

Merging #4226 (1b04d22) into main (986754c) will decrease coverage by 0.59%. The diff coverage is n/a.

:exclamation: Current head 1b04d22 differs from pull request most recent head 2e7edee. Consider uploading reports for the commit 2e7edee to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4226      +/-   ##
==========================================
- Coverage   64.41%   63.81%   -0.60%     
==========================================
  Files         393      388       -5     
  Lines       55542    55230     -312     
==========================================
- Hits        35775    35245     -530     
- Misses      17147    17388     +241     
+ Partials     2620     2597      -23     
Flag Coverage Δ
integration-tests 34.46% <0.00%> (-0.07%) :arrow_down:
kind-e2e-tests 48.98% <0.00%> (+0.08%) :arrow_up:
unit-tests 46.57% <0.00%> (-1.55%) :arrow_down:
Impacted Files Coverage Δ
pkg/agent/cniserver/ipam/antrea_ipam.go 51.08% <0.00%> (-24.68%) :arrow_down:
pkg/agent/route/route_linux.go 53.36% <0.00%> (-18.30%) :arrow_down:
pkg/antctl/raw/multicluster/init.go 66.66% <0.00%> (-8.00%) :arrow_down:
pkg/agent/cniserver/server.go 74.34% <0.00%> (-3.41%) :arrow_down:
...agent/flowexporter/connections/deny_connections.go 87.09% <0.00%> (-3.23%) :arrow_down:
pkg/agent/controller/networkpolicy/reject.go 73.39% <0.00%> (-2.96%) :arrow_down:
pkg/agent/controller/networkpolicy/packetin.go 74.32% <0.00%> (-2.71%) :arrow_down:
...g/agent/controller/serviceexternalip/controller.go 79.18% <0.00%> (-2.39%) :arrow_down:
pkg/agent/client.go 76.74% <0.00%> (-2.33%) :arrow_down:
pkg/ovs/ovsctl/ofctl.go 52.05% <0.00%> (-2.06%) :arrow_down:
... and 30 more

codecov[bot] avatar Sep 15 '22 01:09 codecov[bot]

/test-all

wenqiq avatar Sep 15 '22 03:09 wenqiq

/test-conformance /test-e2e /test-ipv6-e2e /test-multicluster-e2e /test-ipv6-conformance /test-windows-e2e /test-windows-conformance

wenqiq avatar Sep 26 '22 02:09 wenqiq

/skip-all

wenqiq avatar Oct 18 '22 02:10 wenqiq

/skip-all

wenqiq avatar Oct 18 '22 02:10 wenqiq

@antoninbas @luolanzone It seems that the Codecov comment report in PR is not reliable most of the time, this can be confusing for the team members viewing the pull request. I think there are three reasons: 1. too many uploads in each commit CI and each rebase will retrigger the CI pipeline thus causing more reports uploading(Codecov bot comments); 2. carryforward is true; 3. small inaccuracies of Codecov. After discussing and we think it is better to close the Codecov bot comment function temporarily. Do you have a better solution for this?

wenqiq avatar Oct 28 '22 00:10 wenqiq

@wenqiq I am OK to remove the report for now considering it causes a lot of confusion.

luolanzone avatar Oct 28 '22 01:10 luolanzone

@antoninbas @luolanzone @tnqn Do you have any more comments about this codecov config change?

wenqiq avatar Feb 03 '23 02:02 wenqiq

/skip-all

tnqn avatar Mar 17 '23 02:03 tnqn