antrea icon indicating copy to clipboard operation
antrea copied to clipboard

[ExternalNode] Implement SupportBundleCollection on Controller

Open wenyingd opened this issue 2 years ago • 4 comments

  1. Add internal objects to sync the suport bundle collection request from Controller to Agent.
  2. Implement support bundle collection on Controlelr side.

Signed-off-by: wenyingd [email protected]

wenyingd avatar Aug 31 '22 12:08 wenyingd

Codecov Report

Merging #4184 (e101c6c) into main (835e142) will decrease coverage by 2.51%. The diff coverage is 75.31%.

:exclamation: Current head e101c6c differs from pull request most recent head 76b96dd. Consider uploading reports for the commit 76b96dd to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4184      +/-   ##
==========================================
- Coverage   64.38%   61.87%   -2.52%     
==========================================
  Files         393      389       -4     
  Lines       55538    55142     -396     
==========================================
- Hits        35760    34117    -1643     
- Misses      17188    18498    +1310     
+ Partials     2590     2527      -63     
Flag Coverage Δ
integration-tests 34.89% <57.14%> (+0.28%) :arrow_up:
kind-e2e-tests 45.15% <10.95%> (-3.72%) :arrow_down:
unit-tests 44.21% <71.27%> (-3.94%) :arrow_down:
Impacted Files Coverage Δ
cmd/antrea-controller/controller.go 0.00% <0.00%> (ø)
pkg/apis/controlplane/types.go 100.00% <ø> (ø)
pkg/apis/controlplane/v1beta2/helper.go 100.00% <ø> (ø)
pkg/features/antrea_features.go 60.00% <ø> (ø)
pkg/controller/supportbundlecollection/validate.go 70.83% <70.83%> (ø)
...g/controller/supportbundlecollection/controller.go 75.92% <75.92%> (ø)
...istry/controlplane/supportbundlecollection/rest.go 79.48% <79.48%> (ø)
...roller/supportbundlecollection/store/collection.go 81.69% <81.69%> (ø)
pkg/apis/controlplane/register.go 85.18% <100.00%> (-6.49%) :arrow_down:
pkg/apis/controlplane/v1beta2/conversion.go 66.66% <100.00%> (ø)
... and 114 more

codecov[bot] avatar Aug 31 '22 13:08 codecov[bot]

/test-all /test-ipv6-all /test-windows-all

wenyingd avatar Sep 09 '22 09:09 wenyingd

Seems that we also need to update pkg/apis/controlplane/v1beta2/conversion.go, like other internal objects?

Thanks for catching it, updated.

wenyingd avatar Sep 22 '22 09:09 wenyingd

/test-all /test-windows-all /test-multicluster-e2e

wenyingd avatar Sep 28 '22 02:09 wenyingd

/test-all

wenyingd avatar Oct 17 '22 06:10 wenyingd

LGTM, typo in commit message: Controlelr

updated.

wenyingd avatar Oct 26 '22 08:10 wenyingd

/test-all

wenyingd avatar Oct 26 '22 08:10 wenyingd

Update commit message only.

wenyingd avatar Oct 26 '22 10:10 wenyingd

/test-all

wenyingd avatar Oct 27 '22 02:10 wenyingd