antrea icon indicating copy to clipboard operation
antrea copied to clipboard

Support updating the antrea/base-windows image with Github Actions

Open antoninbas opened this issue 3 years ago • 1 comments

At the moment, updating this image is a very manual process and requires access to a Windows machine. To simplify this process, we add a new Github Workflow which can be used to manually trigger a Docker image build and push on Github hosted Windows workers.

Ideally, the workflow would not need to be triggered manually and would run as part of CI (like we do for Linux base images). However this is a good compromise / first step. Even with Docker caching, running ./hack/build-antrea-windows-all.sh for every pull request and push event may be a bit too expensive. Something that can be investigated later.

Signed-off-by: Antonin Bas [email protected]

antoninbas avatar Aug 12 '22 00:08 antoninbas

Codecov Report

Merging #4109 (546f7ca) into main (39b0eb5) will decrease coverage by 1.70%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4109      +/-   ##
==========================================
- Coverage   67.10%   65.40%   -1.71%     
==========================================
  Files         299      304       +5     
  Lines       45443    46775    +1332     
==========================================
+ Hits        30494    30591      +97     
- Misses      12564    13751    +1187     
- Partials     2385     2433      +48     
Flag Coverage Δ
integration-tests 34.96% <ø> (-0.54%) :arrow_down:
kind-e2e-tests 48.90% <ø> (-0.90%) :arrow_down:
unit-tests 43.93% <ø> (-0.40%) :arrow_down:
Impacted Files Coverage Δ
.../agent/flowexporter/priorityqueue/priorityqueue.go 65.55% <0.00%> (-27.78%) :arrow_down:
pkg/util/k8s/name.go 8.00% <0.00%> (-16.00%) :arrow_down:
...nt/apiserver/handlers/serviceexternalip/handler.go 37.03% <0.00%> (-14.82%) :arrow_down:
pkg/signals/signals.go 87.50% <0.00%> (-12.50%) :arrow_down:
pkg/agent/util/net_linux.go 32.25% <0.00%> (-11.70%) :arrow_down:
pkg/agent/openflow/framework.go 89.92% <0.00%> (-10.08%) :arrow_down:
pkg/ovs/ovsctl/appctl.go 34.17% <0.00%> (-7.69%) :arrow_down:
pkg/apiserver/certificate/certificate.go 70.37% <0.00%> (-6.49%) :arrow_down:
pkg/controller/networkpolicy/tier.go 50.00% <0.00%> (-5.00%) :arrow_down:
pkg/agent/interfacestore/interface_cache.go 80.92% <0.00%> (-4.08%) :arrow_down:
... and 50 more

codecov[bot] avatar Aug 12 '22 00:08 codecov[bot]

/skip-all

antoninbas avatar Aug 22 '22 23:08 antoninbas