antrea icon indicating copy to clipboard operation
antrea copied to clipboard

Update codecov setting for test coverge check

Open luolanzone opened this issue 3 years ago • 3 comments
trafficstars

  1. Add codecov/patch status to ensure patch unit-test coverage. Reference: https://docs.codecov.com/docs/commit-status
  2. Update codecov ignore list.
  3. Add github_checks annotations, and lines that are added on a commit without coverage will show up in the pull request files view with an annotation. You can hide annotations in the files view by just pressing 'a', or unselecting "Show annotations" in the top right of the file. Reference: https://docs.codecov.com/docs/github-checks#annotations-in-the-checks-tab

For #3943 Signed-off-by: Lan Luo [email protected] Signed-off-by: Wenqi Qiu [email protected]

luolanzone avatar Jul 11 '22 09:07 luolanzone

Codecov Report

Merging #3986 (04f97ad) into main (d9c4629) will increase coverage by 6.25%. The diff coverage is n/a.

:exclamation: Current head 04f97ad differs from pull request most recent head 82b3fc6. Consider uploading reports for the commit 82b3fc6 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3986      +/-   ##
==========================================
+ Coverage   61.26%   67.51%   +6.25%     
==========================================
  Files         293      294       +1     
  Lines       43686    43764      +78     
==========================================
+ Hits        26765    29549    +2784     
+ Misses      14693    11906    -2787     
- Partials     2228     2309      +81     
Flag Coverage Δ *Carryforward flag
integration-tests 35.93% <ø> (?)
kind-e2e-tests 50.53% <ø> (+6.29%) :arrow_up:
unit-tests 44.20% <ø> (-0.02%) :arrow_down: Carriedforward from b70635e

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
pkg/ipfix/ipfix_process.go 81.25% <0.00%> (-18.75%) :arrow_down:
.../flowexporter/connections/conntrack_connections.go 66.66% <0.00%> (-4.29%) :arrow_down:
pkg/controller/ipam/antrea_ipam_controller.go 76.41% <0.00%> (-2.63%) :arrow_down:
pkg/agent/ipassigner/local_ip_detector_linux.go 75.75% <0.00%> (-1.02%) :arrow_down:
pkg/agent/agent.go 53.11% <0.00%> (ø)
pkg/agent/util/iptables/iptables.go 45.07% <0.00%> (ø)
...icluster/controllers/multicluster/common/helper.go 58.00% <0.00%> (ø)
pkg/agent/controller/networkpolicy/reconciler.go 69.02% <0.00%> (+0.12%) :arrow_up:
pkg/agent/flowexporter/exporter/exporter.go 77.97% <0.00%> (+0.24%) :arrow_up:
...gent/controller/noderoute/node_route_controller.go 56.12% <0.00%> (+0.36%) :arrow_up:
... and 70 more

codecov-commenter avatar Jul 11 '22 10:07 codecov-commenter

/test-all

wenqiq avatar Jul 19 '22 09:07 wenqiq

/test-flexible-ipam-e2e /test-ipv6-e2e /test-multicluster-e2e /test-windows-e2e

wenqiq avatar Jul 20 '22 08:07 wenqiq

@tnqn @antoninbas Could you help to review if it's ready to merge? thanks.

luolanzone avatar Aug 18 '22 07:08 luolanzone

/skip-all

tnqn avatar Aug 23 '22 16:08 tnqn