antrea icon indicating copy to clipboard operation
antrea copied to clipboard

Published 20 hours ago • verified publisher icon antrea-io

Improve support for Egress in Traceflow

Open Atish-iaf opened this issue 2 years ago • 6 comments

Add an Observation in result of Traceflow for Egress which include Egress component, Egress IP and Egress name.

Add a mark RemoteSNATRegMark to indicate remote SNAT for remote Egress traffic. This mark helps to distinguish this traffic from Inter-Node Pod-to-Pod traffic on source Node when Egress IP is equal to a remote Node IP (static Egress).

Add e2e test for Egress in Traceflow for two cases.

  1. Egress from local Node.
  2. Egress from remote Node.

Fixes #2247

Signed-off-by: Kumar Atish [email protected]

Atish-iaf avatar Jun 22 '22 04:06 Atish-iaf

Codecov Report

Merging #3926 (c9c1b2c) into main (c9c1b2c) will not change coverage. The diff coverage is n/a.

:exclamation: Current head c9c1b2c differs from pull request most recent head 8e45f4c. Consider uploading reports for the commit 8e45f4c to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3926   +/-   ##
=======================================
  Coverage   67.68%   67.68%           
=======================================
  Files         402      402           
  Lines       57253    57253           
=======================================
  Hits        38754    38754           
  Misses      15805    15805           
  Partials     2694     2694
Flag Coverage Δ
integration-tests 34.63% <0.00%> (ø)
kind-e2e-tests 46.85% <0.00%> (ø)
unit-tests 56.47% <0.00%> (ø)

codecov-commenter avatar Jun 22 '22 05:06 codecov-commenter

@tnqn Can you please review this PR ?

Atish-iaf avatar Aug 23 '22 12:08 Atish-iaf

@tnqn Can you please review this PR ? Thanks.

Atish-iaf avatar Sep 19 '22 04:09 Atish-iaf

/test-all

tnqn avatar Sep 20 '22 17:09 tnqn

/test-all

tnqn avatar Sep 22 '22 16:09 tnqn

@Atish-iaf our current gating requires good unit test coverage to merge a PR, as the failed "codecov/patch" shows. Would you please add unit tests for new code added by this PR to meet the target?

tnqn avatar Sep 23 '22 01:09 tnqn

@Atish-iaf release-1.9 code freeze is tomorrow, do you have time to add unit test so we can include it in 1.9?

tnqn avatar Oct 18 '22 14:10 tnqn

@Atish-iaf release-1.9 code freeze is tomorrow, do you have time to add unit test so we can include it in 1.9?

Sorry, I cannot make it before 1.9

Atish-iaf avatar Oct 18 '22 16:10 Atish-iaf

@tnqn Can you please review this PR ? Thanks

Atish-iaf avatar Dec 15 '22 12:12 Atish-iaf

Traceflow related e2e test failed, please check

tnqn avatar Dec 18 '22 16:12 tnqn

Traceflow related e2e test failed, please check

@tnqn I had checked it but i don't think it is related to change in this PR.

Atish-iaf avatar Dec 18 '22 17:12 Atish-iaf

Traceflow related e2e test failed, please check

@tnqn I had checked it but i don't think it is related to change in this PR.

I believe it's caused by the PR's change made to compareObservations

tnqn avatar Dec 19 '22 04:12 tnqn

Traceflow related e2e test failed, please check

@tnqn I had checked it but i don't think it is related to change in this PR.

I believe it's caused by the PR's change made to compareObservations

Thanks @tnqn , e2e test fixed, please help to review again.

Atish-iaf avatar Dec 19 '22 13:12 Atish-iaf

/test-all

tnqn avatar Dec 19 '22 13:12 tnqn