antrea icon indicating copy to clipboard operation
antrea copied to clipboard

[CI][e2e] Wait for Service to be realized in proxy tests #2275

Open Atish-iaf opened this issue 2 years ago • 5 comments

Change the mechanism to wait for nginx Services to be realized from sleep for a fixed length of time into polling of flows and groups to make sure that it contains required flows and groups.

Fixes #2275

Signed-off-by: Kumar Atish [email protected]

Atish-iaf avatar Mar 10 '22 12:03 Atish-iaf

Codecov Report

Merging #3429 (4155471) into main (ab31a6c) will decrease coverage by 3.04%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3429      +/-   ##
==========================================
- Coverage   64.45%   61.41%   -3.05%     
==========================================
  Files         294      294              
  Lines       44672    44672              
==========================================
- Hits        28795    27436    -1359     
- Misses      13557    14945    +1388     
+ Partials     2320     2291      -29     
Flag Coverage Δ
kind-e2e-tests 44.18% <ø> (-6.69%) :arrow_down:
unit-tests 44.46% <ø> (+<0.01%) :arrow_up:
Impacted Files Coverage Δ
pkg/agent/proxy/endpointslicecache.go 0.00% <0.00%> (-83.60%) :arrow_down:
pkg/agent/secondarynetwork/cnipodcache/cache.go 0.00% <0.00%> (-77.56%) :arrow_down:
pkg/controller/egress/store/egressgroup.go 1.72% <0.00%> (-54.32%) :arrow_down:
...g/agent/controller/serviceexternalip/controller.go 35.83% <0.00%> (-45.74%) :arrow_down:
pkg/agent/secondarynetwork/podwatch/controller.go 0.00% <0.00%> (-39.02%) :arrow_down:
pkg/agent/cniserver/ipam/antrea_ipam.go 51.08% <0.00%> (-22.95%) :arrow_down:
...nt/apiserver/handlers/serviceexternalip/handler.go 29.62% <0.00%> (-22.23%) :arrow_down:
pkg/agent/util/net.go 26.50% <0.00%> (-21.69%) :arrow_down:
pkg/agent/openflow/pod_connectivity.go 46.62% <0.00%> (-19.67%) :arrow_down:
pkg/agent/route/route_linux.go 27.82% <0.00%> (-18.13%) :arrow_down:
... and 50 more

codecov-commenter avatar Mar 17 '22 10:03 codecov-commenter

/test-e2e

luolanzone avatar Mar 18 '22 13:03 luolanzone

Seems there are some copy-pastes for checking ovs-ofctl dump-flows and "ovs-ofctl dump-groups. Could you help to refactor them to shared functions?

done.

Atish-iaf avatar Apr 28 '22 21:04 Atish-iaf

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days

github-actions[bot] avatar Jul 28 '22 00:07 github-actions[bot]

@tnqn @xliuxu Can you please review this PR ? Thanks.

Atish-iaf avatar Aug 08 '22 09:08 Atish-iaf

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days

github-actions[bot] avatar Nov 07 '22 00:11 github-actions[bot]