sapper-ie icon indicating copy to clipboard operation
sapper-ie copied to clipboard

Upgrade dependencies

Open benmccann opened this issue 5 years ago • 3 comments

Updates the package-lock to get rid of some warnings on the console

benmccann avatar Sep 18 '20 00:09 benmccann

As a template, I don't think a lockfile belongs in here at all.

As a generic IE template, I'd argue @beyonk/sapper-httpclient also doesn't really belong here.

The command in the npm script to manually copy over the dev version of shimport also should be removed, and won't work on Windows anyway.

Conduitry avatar Sep 18 '20 03:09 Conduitry

I guess it depends if you think of it as a template or an example project. I'm fine either way

I just sent a PR for the shimport thing: https://github.com/antony/sapper-ie/pull/13

benmccann avatar Sep 18 '20 05:09 benmccann

The reason @beyonk/sapper-httpclient was in here is because it was a library which caused me specific trouble during my first attempt at making an IE-ready Sapper template. It can probably be replaced with some specific troublesome lines of JS now, or a node_module doing something similar. It's a way of testing that the babel config still works.

antony avatar Sep 18 '20 08:09 antony

Woah this notification was a blast from the past.

Conduitry avatar Jul 31 '24 15:07 Conduitry

Yeah :laughing: I was cleaning out my PR queue...

benmccann avatar Jul 31 '24 16:07 benmccann