QArchive icon indicating copy to clipboard operation
QArchive copied to clipboard

Add zstd support

Open dprotti opened this issue 3 years ago • 4 comments

Select your issue type: (check at least one)

  • [ ] Bug
  • [ ] Question
  • [x] Suggestion
  • [ ] Other (please describe):

Describe your issue:

QArchive is a wrapper around libarchive, a library which already supports zstandard compression algorithm. However QArchive does not include zstd among its QArchiveFormats. In our company we use zstd extensively so would be great to be able to use QArchive to handle this data format.

dprotti avatar Feb 15 '22 13:02 dprotti

I've been working on this in the past days. The compression and extraction works but the memory based compression and extraction is not working well. I think there is some callbacks which I need to properly implement. (notably the archive_read_skip callback). Since some callbacks are crucial for different types of archives.

antony-jr avatar Feb 20 '22 13:02 antony-jr

Thank you very much for your work on this! I'll be happy once this work completes, and for sure many users of your library. Zstd is a great algorithm so would be very valuable to have it available on QArchive.

dprotti avatar Feb 22 '22 00:02 dprotti

Hi Antony-jr, I am also interested in this issue. Are there any updates on this?

moyamartin avatar May 02 '22 19:05 moyamartin

@moyamartin Yeah, almost complete. Only one test is failing in memory based extraction for zstd (I might be doing something wrong). Take a look at the progress in this new branch -> https://github.com/antony-jr/QArchive/tree/zstd

antony-jr avatar May 03 '22 05:05 antony-jr

Thanks for implementing and closing this ticket. Do you plan to have a new release soon?

moyamartin avatar Oct 31 '22 15:10 moyamartin

Yes. After a little bit of nitpicks.

antony-jr avatar Oct 31 '22 18:10 antony-jr

Thanks @antony-jr let me know when you have a new release so I can update the dependency! Have a nice week

moyamartin avatar Nov 01 '22 12:11 moyamartin

Thanks @antony-jr let me know when you have a new release so I can update the dependency! Have a nice week

@moyamartin The latest release now has zstd support.

antony-jr avatar Nov 02 '22 19:11 antony-jr

@antony-jr thank you very much for your work on this! We'll be integrating this new version soon to our systems and let you know how it goes.

dprotti avatar Nov 14 '22 12:11 dprotti