vue-unicons icon indicating copy to clipboard operation
vue-unicons copied to clipboard

fix(types): update / fix types declaration file

Open geopic opened this issue 3 years ago • 6 comments

Resolves #14, #21. Let me know if there are any issues.


Thank you for your contribution to the vue-unicons repo. Before submitting this PR, please make sure:

  • [x] Your code builds clean without any errors or warnings
  • [x] Your commits follow the сonvention

What kind of change does this PR introduce? (check at least one)

  • [x] Bugfix
  • [ ] Feature
  • [ ] Refactor

Importantly

To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on PR.

geopic avatar Nov 19 '20 23:11 geopic

@geopic there are conflicts here, please fix them if you want the PR to be accepted.

antonreshetov avatar Mar 25 '21 14:03 antonreshetov

I'll get down to it soon @antonreshetov :ok_hand:

geopic avatar Apr 01 '21 14:04 geopic

Sorted @antonreshetov

geopic avatar Apr 02 '21 10:04 geopic

@geopic Please read the README, version 3 has changes that are not represented in your code.

antonreshetov avatar Apr 02 '21 11:04 antonreshetov

@geopic The src folders are deleted before bundling, so won't this fail for anyone who npm installs?

dwelch2344 avatar Nov 23 '21 19:11 dwelch2344

@geopic could this pr still be fixed and merged? And could it be used for Vue3?

martn001 avatar Jan 30 '23 12:01 martn001