vue-unicons
vue-unicons copied to clipboard
fix(types): update / fix types declaration file
Resolves #14, #21. Let me know if there are any issues.
Thank you for your contribution to the vue-unicons repo. Before submitting this PR, please make sure:
- [x] Your code builds clean without any errors or warnings
- [x] Your commits follow the сonvention
What kind of change does this PR introduce? (check at least one)
- [x] Bugfix
- [ ] Feature
- [ ] Refactor
Importantly
To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on PR.
@geopic there are conflicts here, please fix them if you want the PR to be accepted.
I'll get down to it soon @antonreshetov :ok_hand:
Sorted @antonreshetov
@geopic Please read the README, version 3 has changes that are not represented in your code.
@geopic The src folders are deleted before bundling, so won't this fail for anyone who npm installs?
@geopic could this pr still be fixed and merged? And could it be used for Vue3?