Anton Pirker

Results 359 comments of Anton Pirker

Updated the branch to use the new workflow generation script. When running the tests locally with `tox -f py313` everything is green. Should be the same in CI now. @xrmx...

All GH checks (except the changelog one) succeeded. (fixed this in the mean time) So I guess this is good to review!

@xrmx moved those commits into new PR: https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2887/

Example traces for both scenarios: 1) Sentry: https://sentry-sdks.sentry.io/performance/trace/060236bb8c7c4964b5dc902457ed6878/?node=txn-915f3493bb3e4f66864523ca78ce21b6&project=5461230&query=http.method%3AGET&referrer=performance-transaction-summary&showTransactions=recent&source=performance_transaction_summary&statsPeriod=1h&timestamp=1719405647&transaction=%2Fapi%2Fshows%2F%7Bpk%7D%2F&unselectedSeries=p100%28%29&unselectedSeries=avg%28%29 2) Sentry using Otel: https://sentry-sdks.sentry.io/performance/trace/13998512b73fbf891922ecfdda42d544/?node=txn-b9a55d514601420aa11b1e9ddcb44c7e&project=5461230&query=http.method%3AGET&referrer=performance-transaction-summary&showTransactions=recent&source=performance_transaction_summary&statsPeriod=1h&timestamp=1719499933&transaction=GET+api%2Fshows%2F%28%3FP%3Cpk%3E%5B%5E%2F.%5D%2B%29%2F%24&unselectedSeries=p100%28%29&unselectedSeries=avg%28%29

### Scenario 1) Sentry ![Image](https://github.com/getsentry/sentry-python/assets/202325/0aeab9b4-c0d5-414a-b419-471a561331e9) [Trace in Sentry.io](https://sentry-sdks.sentry.io/performance/trace/060236bb8c7c4964b5dc902457ed6878/?node=txn-915f3493bb3e4f66864523ca78ce21b6&project=5461230&query=http.method%3AGET&referrer=performance-transaction-summary&showTransactions=recent&source=performance_transaction_summary&statsPeriod=1h&timestamp=1719405647&transaction=%2Fapi%2Fshows%2F%7Bpk%7D%2F&unselectedSeries=p100%28%29&unselectedSeries=avg%28%29)

### Scenario 2) Sentry using Opentelementry ![Image](https://github.com/getsentry/sentry-python/assets/202325/10cfb1cd-fa9f-47ad-ab92-091757de7f8c) [Trace in Sentry.io](https://sentry-sdks.sentry.io/performance/trace/13998512b73fbf891922ecfdda42d544/?node=txn-b9a55d514601420aa11b1e9ddcb44c7e&project=5461230&query=http.method%3AGET&referrer=performance-transaction-summary&showTransactions=recent&source=performance_transaction_summary&statsPeriod=1h&timestamp=1719499933&transaction=GET+api%2Fshows%2F%28%3FP%3Cpk%3E%5B%5E%2F.%5D%2B%29%2F%24&unselectedSeries=p100%28%29&unselectedSeries=avg%28%29)

Things that I noticed: - Otel does not create Spans for middleware, view rendering, or Django signals (that is the `Missing Instrumentation` block in Otel trace) - One can see...

One thing of note: Database spans in OTel include a special structured comment that includes tracing and other information: ![Image](https://github.com/getsentry/sentry-python/assets/202325/28fbba15-24b9-48c2-8801-4874208c989a)

OTel database spans also include information about the HTTP server they where running in: ![Image](https://github.com/getsentry/sentry-python/assets/202325/727bc99e-a11c-4ef4-9a15-8fd39a7723eb)