mpv-youtube-dl-binding icon indicating copy to clipboard operation
mpv-youtube-dl-binding copied to clipboard

Make compatible with multiprocess or rewrite to WebExtensions

Open GoodGuyNick opened this issue 8 years ago • 9 comments

Extension incompatible with Firefox multiprocess. You can check it using Add-on Compatibility Reporter. Update on Compatibility Milestones:

Firefox won’t run in multiprocess mode unless all enabled add-ons have the multiprocessCompatible flag set to true or are WebExtensions. This means that developers who haven’t set this flag don’t have to worry about multiprocess compatibility and can focus on WebExtensions and the Firefox 57 deadline.

GoodGuyNick avatar May 02 '17 20:05 GoodGuyNick

Seems to be working when you force it
https://wiki.mozilla.org/Electrolysis#Force_Enable
But I agree it would be nice to have it working for everyone who does not know about this or does not want to use this hack

utack avatar Jun 15 '17 23:06 utack

This extension makes my browsing ten times better, please don't let it die with FF 56, @antoniy.

skorokithakis avatar Sep 03 '17 00:09 skorokithakis

alternatively, you can drag urls out of links or the adressbar directly into MPV to make it work. holding shift while doing so even adds files to the playlist.

isn't as instantaneous, as you have to open the player first, but better than nothing.

monochrony avatar Nov 14 '17 23:11 monochrony

I have a poc running right now, need to clean it a bit and I will send a pull request. Basically I use a python wrapper as a native app to call the selected player with subprocess.run().

dummys avatar Nov 22 '17 22:11 dummys

I think this project is dead so I've switched to Open With.

GoodGuyNick avatar Nov 22 '17 23:11 GoodGuyNick

Thanks for the tip @GoodGuyNick, there's no keyboard shortcut with that option though.

maxime-michel avatar Nov 24 '17 13:11 maxime-michel

I pull requested one @ open_with github, checkit

On 24 Nov 2017 14:57, "Maxime Michel" [email protected] wrote:

Thanks for the tip @GoodGuyNick https://github.com/goodguynick, there's no keyboard shortcut with that option though.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/antoniy/mpv-youtube-dl-binding/issues/40#issuecomment-346834271, or mute the thread https://github.com/notifications/unsubscribe-auth/AB2fxacayrQddBv-iZD6cwhN9kUdkeWyks5s5stOgaJpZM4NOoZv .

dummys avatar Nov 24 '17 14:11 dummys

Yeah, I did see that. However, I'm switching to qutebrowser. It might not float everybody's boat, but as a Vimmer I like it. And that plugin is a one-liner with it:

config.bind(',m', 'spawn /usr/local/bin/mpv {url} --pause --keep-open')

maxime-michel avatar Nov 24 '17 16:11 maxime-michel

A bit late to the party, but I created ff2mpv as a WebExtension clone for mpv-youtube-dl-binding. It provides the same context menu/toolbar interface as this plugin did, and nothing else.

woodruffw avatar Dec 21 '17 21:12 woodruffw