countries icon indicating copy to clipboard operation
countries copied to clipboard

What makes this package require PHP 7?

Open dugajean opened this issue 7 years ago • 2 comments

Without going through the whole package, I would like to know what PHP 7 syntax is being used in this package. Anyone care to help me find out? I would like to create compatibility with PHP 5.6.

Thanks.

dugajean avatar Apr 01 '17 21:04 dugajean

Same question here.

Would be great if the author could explain the reasoning behind making this package compulsory for PHP 7+.

mohitpanjwani avatar Apr 13 '17 13:04 mohitpanjwani

As far as I can remember, there is some dependencies with PHP 7. The PHPUnit version which is being used required PHP 7.

Also here https://github.com/antonioribeiro/countries/blob/master/src/Support/Collection.php#L153 we use type hinting, which first got introduced in PHP 7.

The same is happening in https://github.com/antonioribeiro/countries/blob/master/src/Support/ExportData.php#L11 and some other places.

But you should be able to convert it to PHP 5.6, the reason is just why would you do this and not just upgrade to PHP 7+?

olivernybroe avatar Apr 25 '17 10:04 olivernybroe