coollection icon indicating copy to clipboard operation
coollection copied to clipboard

Update dependencies to make it compatible with Laravel9

Open asbiin opened this issue 2 years ago • 3 comments

Description

Update pragmarx/ia-collection, pragmarx/ia-str and pragmarx/ia-arr dependencies. Also remove composer.lock and update travis config file.

Motivation and context

Laravel 9.x requires symfony/var-dumper ^6.0 and voku/portable-ascii ^2.0. This is part of some updates on multiple pragmarx packages which aren't compatible with Laravel9 yet, this helps fixing that.

See

  • https://github.com/antonioribeiro/ia-str/pull/5
  • https://github.com/antonioribeiro/ia-collection/pull/11
  • https://github.com/antonioribeiro/ia-arr/pull/4

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • [x] I have read the CONTRIBUTING document.
  • [x] My pull request addresses exactly one patch/feature.
  • [x] I have created a branch for this patch/feature.
  • [x] Each individual commit in the pull request is meaningful.
  • [x] I have added tests to cover my changes.
  • [x] If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

asbiin avatar May 06 '22 12:05 asbiin

Been over a month this commit has been open for. @antonioribeiro any update if this is going to be accepted soon as I would like myself to upgrade a project to Larave v9 but this is stopping me.

DubStepMad avatar Jun 12 '22 11:06 DubStepMad

@asbiin Sorry to be a pain but any update from your side? Does state this is still a work in progress.

DubStepMad avatar Jun 16 '22 18:06 DubStepMad

@asbiin Sorry to be a pain but any update from your side? Does state this is still a work in progress.

I am not the maintainer of the repo, and it does not seem to care anymore. I don't need this package myself, I'll left the PR as is but I am not working nor waiting on it.

asbiin avatar Aug 14 '22 16:08 asbiin