Antonio Andelic
Antonio Andelic
@zk-kiger could you try setting `force_sync` to `false` under `keeper_server.coordination_settings`? This will disable flush on each Raft log (just for benchmarking purposes). I'm not sure what ZK does in this...
https://s3.amazonaws.com/clickhouse-test-reports/42532/e3cdc5ed7a6c4bfa7aad93007f1d3b43245df31c/stateless_tests__asan__[1/2].html
@jrdi I'll try to wrap it up. Thanks for pinging, it ended up staying in an unknown state for a really long time.
Continuation in #42423
This breaks `test_replicated_database/test.py::test_startup_without_zk` because you didn't add sleep after checking exception message https://s3.amazonaws.com/clickhouse-test-reports/60109/0496d0f45fa6d07038a32de93f6f65ed02f0c971/integration_tests__asan_.html
@tavplubix most likely fixed with https://github.com/ClickHouse/ClickHouse/pull/61717
Race probably introduced by this PR https://s3.amazonaws.com/clickhouse-test-reports/59460/0be66e95762ed82f971be3dc64e783fcb279abf3/stateless_tests__tsan__s3_storage_/stderr.log
@josh-hildred can you please update the branch with master one more time just so I see that checks are okay
Thanks for implementing this @josh-hildred! And with clean code and good tests, can't ask for more. 😄
There were some performance improvements for write path: https://github.com/ClickHouse/ClickHouse/pull/43686 https://github.com/ClickHouse/ClickHouse/pull/43450 They should be part of 22.12 release, but they can be already tested with [head images](https://hub.docker.com/layers/clickhouse/clickhouse-keeper/head-alpine/images/sha256-679f941d01dfe3f694c6c717bbd21c841a96e84e9026edb9e1a97296962a30dc?context=explore).