Antoni Spaanderman

Results 144 comments of Antoni Spaanderman

> You can sign the sent key with the player's chat reporting key and then verify that on the other player's client, retrying/refusing the key exchange if said signature is...

@kcinnaJlol by the way, this would not be safe on realms, as microsoft owns the chat signing keys

> I am wondering if we could follow a little more #257 and provide a "writer" (maybe start with a `Vec`) to experiment. So that we can return either owned...

> No, with the `zero_copy` method. Not the const one. Do you maybe mean the `encode_writer` method? Right now I have `BytesEncode::bytes_encode_into_writer` which is like it, it uses `&mut Vec`...

In a5c96f1 I used Either (a generic 2 value enum) to return different error types without using dynamic dispatch (`dyn StdError`), this could also solve the issue in #166 with...

> Thank you for that, but I would prefer we keep these PR changes only for trait improvement. So that it's easier to review as less code changes. I'm also...

> Can you `Box` the error for now? We will figure that out later when we have a good trait. Sure, done > In issue #257, we are talking about...

`BytesEncode::size_hint` should also be needed as lmdb wants to know the size before giving the reserved space (right?). I assume then that the writer method will only be used when...

> Another is that it is not valid to implement `Sync` on a `Cursor` (internal) and use this cursor on multiple threads without synchronization. Isn't this impossible already because to...

> Unfortunately, you cannot trust the sole documentation of a C library. I don't know what "The library is fully thread-aware" exactly means but [here is an example of non-thread...