PipeTableFormatter icon indicating copy to clipboard operation
PipeTableFormatter copied to clipboard

Do not remove wrapping quotes

Open xoliver opened this issue 7 years ago • 5 comments

Hi @anton-dev-ua , thank you for this plugin, it's making my life so much easier!

I ran into the issue where running the plugin successive times effectively changes the content of cells, and that has caused me trouble running it multiple times (""a value"" becomes "a value" and then becomes a value). I think a formatting plugin should not alter the values if it can, as registered by somebody else in https://github.com/anton-dev-ua/PipeTableFormatter/issues/11

Here's a proposal for this, I figured I might as well contribute it back so everybody can benefit. I haven't touched the xml file on purpose since I'd like to see if you have reasons for it to behave the current way 😄

Thanks!

xoliver avatar Mar 15 '18 13:03 xoliver

Is this scheduled for release anytime soon?

aanutter avatar Jul 18 '19 17:07 aanutter

Never heard back so I'd guess no?

xoliver avatar Jul 18 '19 19:07 xoliver

@anton-dev-ua If you are still supporting this tool, would be great to get this fixed. It's a subtle bug, so it's easy to overlook on PR's. Especially if you use scenario outline, with large examples tables.

aanutter avatar Jul 18 '19 19:07 aanutter

Hi folks, I helped write the original version with Anton but have lost contact with him several years ago. Generally happy with the suggestions, but do you have any advice for how to apply them to the tool?

idrisahmed251 avatar Jul 18 '19 20:07 idrisahmed251

Hi @idrisahmed251 , I believe this PR opened by @xoliver would address the issue.

aanutter avatar Jul 18 '19 20:07 aanutter