Antoine Beaubien

Results 77 comments of Antoine Beaubien

> Yes but then you need to make sure you can actually disable the replacing, which you have not mentioned in the issue so far, right? https://github.com/OpenRefine/OpenRefine/blob/bef50d989b3c4b4216a5b71e99d4d4187046d0c3/main/src/com/google/refine/exporters/sql/SqlCreateBuilder.java#L85-L94 @wetneb: I feel...

@the-star-sea: in regards to @wetneb last comment, I suggest this user interface: ![image](https://user-images.githubusercontent.com/12217525/171881119-7787c1c7-57f7-41f3-aaf8-09b109bcf3cb.png) What do you think? Regards, Antoine

@andrawaag: I know it's not much and different from what you ask, but it's related in my mind, as it facilitate matching with few information, so at least, we should...

> Thanks! Personally I am not sure I understand the motivation of the original issue. As far as I can tell, #4685 removes non-standard characters so there is no need...

> I have reviewed all my code @the-star-sea: when you are ready for code review, go to the top right of the PR: ![image](https://user-images.githubusercontent.com/12217525/164968712-40d10bce-4990-4f1a-adbe-f1fc940e9be2.png) And there, you can choose @antoine2711,...

> How long is the wait? Is it especially burdensome? @thadguidry: Now, it get to the full timeout of 10 s. Regards, Antoine

@ncarboni: I think you should REALLY consider using the CLI for that. It's really easy to extract the full list, get the subset you want to delete, and then batch...

> Very nice, thank you! Perhaps it could be nice to add a UI test in the same go, just to demonstrate the feature on a facet? @wetneb : like...

@wetneb : thanks for merging this in v3.6. Regards, Antoine

> yes, that's my intention! I will try writing a Cypress for it myself. I’ve just been too busy, I still plan to write the test cases, like I committed...