capnpy icon indicating copy to clipboard operation
capnpy copied to clipboard

capnpy.load(f, payload_type) message size

Open Gw1p opened this issue 5 years ago • 1 comments

capnpy.load(f, payload_type): load a message from a file-like object Should have a maximum message size parameter or internal check to avoid hanging in case a response message is unreasonably large.

Gw1p avatar Jul 16 '19 14:07 Gw1p

yes, it might be a good idea. In general, there are many ways in which a malicious message could affect an implementation. Here are some examples, from the official capnproto docs: https://capnproto.org/encoding.html#security-considerations

Admittedly, capnpy was not implemented with malicious messages in mind. I would not be opposed to add support for it, assuming it doesn't impact performance. It is unlikely I'll do it by myself though, so PR are welcome :)

antocuni avatar Jul 25 '19 12:07 antocuni