password-strength-meter icon indicating copy to clipboard operation
password-strength-meter copied to clipboard

Remove hard dependency to zxcvbn modules

Open HosseinSalmanian opened this issue 2 years ago • 0 comments

Hi As we provide our own implementation for IPasswordStrengthMeterService, there is no need to default PasswordStrengthMeterService. but because imported PasswordStrengthMeterService is the default provided class in PasswordStrengthMeterModule forRoot method, there is a hard dependency on zxcvbnEnPackage. it makes the final app bundle about 1MB larger. I think it would be better to remove the default provider for IPasswordStrengthMeterService and let it be specified in the consumer app module. it will remove the hard dependency on "zxcvbn" Module and the final bundle will be much smaller. thanks in regards.

HosseinSalmanian avatar Aug 10 '22 09:08 HosseinSalmanian