grammars-v4 fix golang interpreted string literals

fix golang interpreted string literals

Open uunnii opened this issue 4 years ago • 5 comments

trafficstars

Nov 06 '21 07:11 uunnii

Could you also provide an example that covers the change?

Nov 06 '21 11:11 KvanTTT

Could you also provide an example that covers the change?

Yes, I added an example in new commits.

Nov 06 '21 13:11 uunnii

Unfortunately, tests are failing: https://github.com/antlr/grammars-v4/runs/4125916381?check_suite_focus=true#step:4:4431 Could take a look?

Nov 06 '21 17:11 KvanTTT

Unfortunately, tests are failing: https://github.com/antlr/grammars-v4/runs/4125916381?check_suite_focus=true#step:4:4431 Could take a look?

Yes. The logs show that the error message for this test case is different on windows and other platforms, and I added a new commit to fix it.

Nov 06 '21 20:11 uunnii

@uunnii I see a merge conflict on this PR and some test failures. Are you planning to continue the PR?

Oct 11 '22 14:10 teverett

@uunnii I am closing this for now. You are welcome to re-open it with merge fixes.

Jan 02 '23 21:01 teverett