antlr4 icon indicating copy to clipboard operation
antlr4 copied to clipboard

[Cpp] Don't define ANTLR4CPP_EXPORTS in *consumers* of ANTLR runtime.

Open BillyONeal opened this issue 2 years ago • 4 comments

This was originally submitted to vcpkg as https://github.com/microsoft/vcpkg/pull/29384

As currently written this is causing consumers of ANTLR's C++ runtime to define ANTLR4CPP_EXPORTS which means they are trying to __declspec(dllexport) rather than __declspec(dllimport) them.

See a repro in https://github.com/microsoft/vcpkg/issues/29326

Signed-off-by: Billy Robert O'Neal III [email protected]

BillyONeal avatar Feb 03 '23 20:02 BillyONeal

(The original author of this change is @TheReclif who deserves credit for authorship, not me)

BillyONeal avatar Feb 03 '23 21:02 BillyONeal

Any progress on this? @BillyONeal

mcmikecreations avatar Sep 28 '23 22:09 mcmikecreations

Any progress on this? @BillyONeal

I'm not aware of additional changes necessary here?

BillyONeal avatar Sep 29 '23 18:09 BillyONeal

Any progress on this? @BillyONeal

I see it didn't merge cleanly so I pushed a merge.

BillyONeal avatar Oct 04 '23 03:10 BillyONeal