antlr4 icon indicating copy to clipboard operation
antlr4 copied to clipboard

Extracted getting the interp file name into a separate method `Tool::getInterpFileName`.

Open KOLANICH opened this issue 3 years ago • 3 comments

KOLANICH avatar Oct 11 '22 13:10 KOLANICH

As with my other comment... We really need to have a good reason to change something for fear we might break somebody's code that relies on the tool.

parrt avatar Nov 20 '22 00:11 parrt

What's the motivation of extracting the method with only single using?

KvanTTT avatar Nov 20 '22 14:11 KvanTTT

What's the motivation of extracting the method with only single using?

To make maintaining my fork with the commits implementing in-memory transpilation #3874 easier. Thanks for mentioning this! I think I need to add a comment saying that this function shouldn't be inlined.

We really need to have a good reason to change something for fear we might break somebody's code that relies on the tool.

I don't know if it is considered a good reason, but I just try to merge some of the changes (usually equivalent ones) needed for #3874 in a careful step by step way.

KOLANICH avatar Nov 21 '22 15:11 KOLANICH