[C++]Can GuidGenerator be removed?

[michalbali256]

Hi,

We are using ANTLR for our C++ project and we had to go through some legal checks. Naturally, it popped out that ANTLR has CoreFoundation as dependency for apple distribution, because it is written in Cmake file.

However, when I have done thorough research I found out that the CoreFoundation (and libuuid on linux and something from windows SDK) library are only used in GuidGenerator::newGuid function, which is never used in whole ANTLR C++ runtime.

So my question is: can it be removed? It would remove much platform-specific code, simplify antlr-common.h, C++ runtime would get rid of CoreFoundation, libuuid and jni dependencies. It seems like an improvement to me.

Or am I missing something?

Thanks, Michal

[songyang-dev]

Have you tested it out? If removing it doesn't break the code, this might be viable.

[Technius]

I believe libuuid is not referenced anywhere in the C++ runtime code, and I can also confirm that the runtime builds successfully with the libuuid code removed (for my local clone, at least).