sds

sds copied to clipboard

Handling realloc fails

1

Addressing issue : 'realloc may return NULL #23'

odeke-em

Hi @antirez, according to the `man page` ``` realloc() returns a pointer to the newly allocated memory, which is suitably aligned for any kind of variable and may be different...

2ghostc

Doing so enormously simplifies error handling; you no longer have to check for memory allocation errors in a chain of sds function calls, only after the last call.

lemzwerg

The idea is that `sds.c` gets compiled with a C99 compliant compiler, and a C++ program then uses it. To do so, it needs access to `sds.h`, and this commit...

lemzwerg

I think having `extern "C"` is common for C libraries...

lemzwerg

Improved patch for issue #11.

lemzwerg

Hi Salvatore. Thanks for releasing this. You should consider using the GCC (and compatible) attribute "warn_unused_result" on the functions that may call realloc(). http://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html#index-g_t_0040code_007bwarn_005funused_005fresult_007d-attribute-2997 It's not a perfect backstop, but...

nkurz

ogay

Change "BDS two clause license" to "BSD two clause license".

1

I wonder if "BDS two clause license" is a spelling mistake or if there is indeed a license called "BDS two clause license".

forhappy

sdsrange(str, 0, -2) should result in an empty string. For example sds str = sdsnew("hello"); while (sdslen(str) > 0) str = sdsrange(str, 0, -2); Would result in an inifinty loop...

iveqy