SDS version 2 compilation error with visual c++ compiler.

Open amod0017 opened this issue 7 years ago • 3 comments

I see there is a fix for version 1 for c++ compiler. Is there anything similar for version 2? Facing compilation issues, like below: Am I missing something?

Mar 06 '18 16:03 amod0017

Old issue but if you're still wondering the problem is MSVC doesn't support that attribute syntax. You can look at the changes I made in my fork (https://github.com/LynnKirby/sds), in particular starting here.

Aug 10 '18 16:08 LynnKirby

I encountered this problem. @LynnKirby what license does your fork use? Would you consider pull requesting your fixes back to this repo?

I feel this issue should be taken seriously...

Nov 07 '18 21:11 mcclure

@mcclure It's the same license as the original (BSD 2-clause). I haven't bothered to pull request the changes since all the other pull requests are dead in the water.

Nov 08 '18 18:11 LynnKirby