redis-rb-cluster
redis-rb-cluster copied to clipboard
Enhancements of the redis-rb-cluster
These are the main enhancements:
- Each redis node has a connection pool(fork safe)
- Can enable to read from slave
- Each redis command has a corresponding ruby method
- Unit tests cover all the commands
- Change indention from 4 to 2....
And some other subtle improvements.
Most of the data structure commands are implemented. However, there are still some missing commands, e.g. pubsub and cluster related specific commands.
And the last, what license of this client will be?
This is quite a big PR, thanks!
Hi @antirez , will you spend some time on reviewing this PR? Thanks a lot..
Hello, sorry I have missed this. Sounds interesting! Please could you return the indentation to 4 spaces? This is a matter of tastes and since the project was organized this way it is outside the context of making it better to adapt it to other coding styles ;-) But overall, this is promising and I waited for some improvements, so thanks!
@antirez :) I actually prefer 4 spaces since I am from Python world. Sure, will do it soon.
@antirez 4 spaces now. :)
Hello, will this be merged soon? I would like to see the changes iandyh made.
@antirez Do you think with this PR, this gem would be production ready? We have been waiting long for a stable Ruby client for Redis cluster and I am glad @landyh is able to help.
Thank you for providing such great gem!
@jerryluk Hi! I'd suggest you test this branch in your environment and report any issues back to me.
Hi, Will you merge this PR. IS it ok for production enviroment?