redis-rb-cluster icon indicating copy to clipboard operation
redis-rb-cluster copied to clipboard

Enhancements of the redis-rb-cluster

Open iandyh opened this issue 10 years ago • 8 comments

These are the main enhancements:

  1. Each redis node has a connection pool(fork safe)
  2. Can enable to read from slave
  3. Each redis command has a corresponding ruby method
  4. Unit tests cover all the commands
  5. Change indention from 4 to 2....

And some other subtle improvements.

Most of the data structure commands are implemented. However, there are still some missing commands, e.g. pubsub and cluster related specific commands.

And the last, what license of this client will be?

This is quite a big PR, thanks!

iandyh avatar Oct 19 '15 05:10 iandyh

Hi @antirez , will you spend some time on reviewing this PR? Thanks a lot..

iandyh avatar Oct 29 '15 05:10 iandyh

Hello, sorry I have missed this. Sounds interesting! Please could you return the indentation to 4 spaces? This is a matter of tastes and since the project was organized this way it is outside the context of making it better to adapt it to other coding styles ;-) But overall, this is promising and I waited for some improvements, so thanks!

antirez avatar Oct 29 '15 07:10 antirez

@antirez :) I actually prefer 4 spaces since I am from Python world. Sure, will do it soon.

iandyh avatar Oct 29 '15 08:10 iandyh

@antirez 4 spaces now. :)

iandyh avatar Oct 30 '15 06:10 iandyh

Hello, will this be merged soon? I would like to see the changes iandyh made.

dsklopp avatar Nov 17 '15 15:11 dsklopp

@antirez Do you think with this PR, this gem would be production ready? We have been waiting long for a stable Ruby client for Redis cluster and I am glad @landyh is able to help.

Thank you for providing such great gem!

jerryluk avatar May 28 '16 01:05 jerryluk

@jerryluk Hi! I'd suggest you test this branch in your environment and report any issues back to me.

iandyh avatar May 30 '16 11:05 iandyh

Hi, Will you merge this PR. IS it ok for production enviroment?

mPanasiewicz avatar Jun 16 '16 13:06 mPanasiewicz