linenoise icon indicating copy to clipboard operation
linenoise copied to clipboard

Fixed two Coverity defects

Open dimkr opened this issue 8 years ago • 4 comments

  1. strlen() on uninitialized string
  2. Ignoring the return value of chmod()

dimkr avatar Aug 15 '17 06:08 dimkr

This implements the same change as https://github.com/antirez/linenoise/pull/151

also adds a (void) cast to chmod, I can understand the value of coverity but I don't see this as a valuable addition at the moment.

This patch does not need to be merged.

rain-1 avatar Mar 30 '18 23:03 rain-1

I can understand the value of coverity but I don't see this as a valuable addition at the moment.

Compiler warnings aside (unused return value, etc'), the value I see is getting rid of one (useless) Coverity error in every project that uses linenoise upstream as a git submodule.

dimkr avatar Apr 01 '18 17:04 dimkr

@rain-1 All of this has been discussed to death, this is done differently than #151, as has been discussed at length as well. @antirez has never chosen to accept these changes but they have been left open if he changes his mind at some future time.

Sonophoto avatar Apr 04 '18 01:04 Sonophoto

Merged https://github.com/rain-1/linenoise/commit/6d759a8183d10c7c039d9a8d163ec30a192d24eb

rain-1 avatar May 15 '18 16:05 rain-1