p5.riso icon indicating copy to clipboard operation
p5.riso copied to clipboard

Cant get examples to work that arent using images

Open eadehemingway opened this issue 3 years ago • 6 comments

I am so excited to use this library, thank you so much for making it!

I'm not sure if I am missing something but it seems lots of examples dont work in the p5 editor (or when I recreate the examples locally) e.g:

  • https://github.com/antiboredom/p5.riso/tree/master/examples/Cutout
Screenshot 2021-12-19 at 15 41 44
  • https://github.com/antiboredom/p5.riso/tree/master/examples/Color_test
Screenshot 2021-12-19 at 15 42 16
  • https://github.com/antiboredom/p5.riso/tree/master/examples/Smudge
Screenshot 2021-12-19 at 15 43 20

Have I missed something? thanks!

eadehemingway avatar Dec 19 '21 15:12 eadehemingway

Hi - can you share a link to the p5 editor sketches that aren't working so I can take a look?

antiboredom avatar Dec 19 '21 23:12 antiboredom

Hi, yeah they are just the links linked in the above links, they are:

  • https://editor.p5js.org/brain/sketches/GpuJH1Zur
  • https://editor.p5js.org/brain/sketches/rCdUW72sC
  • https://editor.p5js.org/brain/sketches/i1gDFtMAI And also this one seems to be broken for a different reason:
  • https://editor.p5js.org/brain/sketches/wLGAPKEMk thanks!

eadehemingway avatar Dec 20 '21 11:12 eadehemingway

That’s odd - all of these seem to be working for me, except for the last one. Are you seeing any errors? Also what browser are you using?

antiboredom avatar Dec 20 '21 21:12 antiboredom

ooh how odd, I am using google chrome... The first three all work in the sense that I can see the shapes but they dont work in the sense that they dont have the riso effect (as shown in the screenshots above). What browser are you using?

eadehemingway avatar Dec 20 '21 22:12 eadehemingway

Ah - I see what you mean. The library doesn't actually generate a riso effect, it's intended to prepare files for riso printing, and to preview what the final prints might look like. The images that we have are scans of actual riso prints that we've made using the library, rather than screen shots. I think we could do more work in the documentation to clarify this. Sorry for the confusion!

antiboredom avatar Dec 22 '21 00:12 antiboredom

oh I see! thanks for the clarification, that makes sense now!

eadehemingway avatar Dec 23 '21 11:12 eadehemingway