joal icon indicating copy to clipboard operation
joal copied to clipboard

WIP: accept tracker connections

Open laur89 opened this issue 2 years ago • 11 comments

~Note this change is on top of #172 -- merge that beforehand.~ merged

laur89 avatar Feb 03 '23 06:02 laur89

Ye this is going to need quite a bit of research/know-how. Would you be willing to merge this as-is, considering it's reportedly solved problem to one user. And possibly/hopefully it improves existing logic somewhat.

laur89 avatar Feb 16 '23 19:02 laur89

Ye this is going to need quite a bit of research/know-how. Would you be willing to merge this as-is, considering it's reportedly solved problem to one user. And possibly/hopefully it improves existing logic somewhat.

Two users. :-) I have been waiting for this merge, and updated Docker image, since the opening of this PR.

WZrocks avatar Mar 19 '23 14:03 WZrocks

Hello there, i've not forgotten about you.

But i'm lacking time to review that. I try to give it a look ASAP

anthonyraymond avatar Mar 27 '23 09:03 anthonyraymond

Do you have any idea if and when you'll have the time to look at this, @anthonyraymond? I don't want to rush you, I'm already very grateful for what you did with this project so far, I'm just looking for an ETA.

WZrocks avatar May 08 '23 12:05 WZrocks

Hello, i'm still unsure if i want to merge this as-is or not. Not sure if that makes its more unsafe or not.

An analogy for this PR is:

  • before nobody won't ever answer the call when the phone rings.
  • Now someone will, but he is clearly not speaking the language that you expect the people to speak. You'll know it's not the person it is supposed to be on the other end.

anthonyraymond avatar May 09 '23 09:05 anthonyraymond

That is a valid point. Would it be possible to make it optional in config? @laur89 @anthonyraymond

WZrocks avatar May 10 '23 19:05 WZrocks

@anthonyraymond i think it's best to just add a toggle in settings. for me it works great but maybe others can have issues, indeed. can't wait to see this merged and published <3

rursache avatar May 26 '23 09:05 rursache

I don't think the config option will come anytime soon either, right? 😔

WZrocks avatar Jun 26 '23 17:06 WZrocks

@anthonyraymond can we please merge this as well? been using it since then and it's all good. maybe add a config toggle in the settings just in case?

rursache avatar Nov 01 '23 10:11 rursache

@rursache i don't think this is ever going to be added as is. It's sounds a bit dangerous for most people.

I'll include a real and complete implementation in the next version (built from scratch), but for now i prefer not to include it as is

anthonyraymond avatar Nov 02 '23 13:11 anthonyraymond

@anthonyraymond I'll include a real and complete implementation in the next version (built from scratch), but for now i prefer not to include it as is

thank you, looking forward to your implementation!

rursache avatar Nov 02 '23 13:11 rursache