Theme doesn't work with other editor themes

[salim-b]

First of all, awesome work, thanks a lot!

Now, while I love your dark menu palettes (and especially the fact that you provide GNOME-specific style sheets!), I don't like the rscodeio editor theme and prefer to stick to Tomorrow Night Bright instead.

Although in #18 you state

Once installed, the menu theme is applied when any dark editor theme is applied;

this is not true for me. The menu theme (except the top menu bar) reverts back to Modern's default ugly blue colors as soon as I switch the editor theme to anything other than rscodeio.

Screenshot (note the top menu bar which is still dark):

Maybe this is because I'm using the latest development version of RStudio (~~1.3.1039~~ 1.3.1050 at the time of writing)?

Excerpt of xfun::session_info():

R version 4.0.2 (2020-06-22)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 20.04 LTS, RStudio 1.3.1050

Locale:
  LC_CTYPE=de_DE.UTF-8       LC_NUMERIC=C               LC_TIME=de_CH.UTF-8        LC_COLLATE=de_DE.UTF-8    
  LC_MONETARY=de_CH.UTF-8    LC_MESSAGES=de_DE.UTF-8    LC_PAPER=de_CH.UTF-8       LC_NAME=C                 
  LC_ADDRESS=C               LC_TELEPHONE=C             LC_MEASUREMENT=de_CH.UTF-8 LC_IDENTIFICATION=C

[anthonynorth]

The menu theme is the top menu bar; this is what is changed when rscodeio::activate_menu_theme() is executed. All of the remaining UI elements are styled with the editor theme.

[salim-b]

I see... so this means, there's currently no way to combine your UI element modifications besides the syntax highlighing theme with the default editor themes provided by RStudio, right?

I guess it would then be a simple copy-paste effort to create an editor theme with all of your awesome UI element mods but with Tomorrow Night Bright syntax higlighting? Would you accept a PR introducing such a second editor theme (with the name Tomorrow Night Bright (rscodeio) for example)?

[raahimSal]

@salim-b Were you able to get around this, I am running into the same issue and want to run a different editor theme but keep all the styling.

Thanks

[anthonynorth]

@salim-b yes that will be ok & sorry for the (very) delayed response.

[raahimSal]

If possible, could the file be changed in a way where the editor themes can just be copy pasted from other sources yet all the other styling remains the same? Haven't done anything like this before so just wondering, Thanks for such a nice theme btw love this alot!

[anthonynorth]

It is possible, but given the way I hacked the stylesheet together, it's probably going to be painful. There are some css variables defined at the top of the stylesheet which you could take a look at; I expect it's incomplete for what you want though. I had intended to refactor that stylesheet into a postcss pipeline, but I haven't had time to complete it, unfortunately.

[salim-b]

@salim-b Were you able to get around this, I am running into the same issue and want to run a different editor theme but keep all the styling.

I've just submitted #44 which adds a theme named Tomorrow Night Bright (rscodeio).

You can use one of RStudio's default themes and complement it by the necessary CSS from rscodeio if you like.