Anthony Kirby comments

Repositories
Issues
Comments

Results 15 comments of


                                            Anthony Kirby

Join Accept details cannot be shown without decrypting using the AppKey

(thank you for the detailed report; I'm scheduling time in September to work on this; apologies for the delay)

Added .toJSON() method to packet.js

I'll review - looks good, thanks!

Added .toJSON() method to packet.js

Hi taraskuzyk, I started writing a test for the new code, but it got me thinking. The function is called "toJSON" but it's not actually returning JSON, it's returning an...

Set DevEUI from userFields for data packet

Hi @emanuele-dedonatis, thank you for the PR. I'm puzzled about the use-case for the change: (Please be patient with me, as I can't remember all the details of the LoRA...

Set DevEUI from userFields for data packet

Sorry, I don't understand. If the packet is a JOIN_REQ then you wouldn't expect it to have a `DevEUI`. (It won't have an `AppEUI` or `DevNonce` either, but the PR...