html-critical-webpack-plugin icon indicating copy to clipboard operation
html-critical-webpack-plugin copied to clipboard

Published 20 hours ago • verified publisher icon anthonygore

Update critical dependency?

Open khalwat opened this issue 5 years ago • 7 comments

Any chance you might update the dependency to critical to ^2.0.0?

https://github.com/addyosmani/critical/blob/master/package.json#L3

khalwat avatar Jun 12 '19 14:06 khalwat

Can take a look, not sure what breaking changes there are. I notice it is at 2.0.0-18, does that mean it is still in pre-release? Or just a custom versioning scheme?

thescientist13 avatar Jun 15 '19 12:06 thescientist13

I would add, we have Continuous Integration in place, so no harm in opening a PR if you feel up for it and we can see how that goes! 👍

thescientist13 avatar Jun 15 '19 12:06 thescientist13

Primary motivation is that older versions of Critical rely on packages that have security vulnerabilities.

khalwat avatar Jun 28 '19 05:06 khalwat

Why it is still not updated?

sanjayojha avatar Jun 06 '20 11:06 sanjayojha

Maybe I can look into this soon, but PRs are also welcome. 👍

thescientist13 avatar Jun 07 '20 19:06 thescientist13

There is a PR for this here https://github.com/anthonygore/html-critical-webpack-plugin/pull/48 but it was not merged yet.

jmartsch avatar Dec 27 '20 09:12 jmartsch

FWIW, a drop-in replacement would be to use this one: https://github.com/lili21/critical-css-webpack-plugin

...which has been updated to use

"critical": "^2.0.0"

khalwat avatar Dec 27 '20 22:12 khalwat