Anthony Burdi

Results 30 comments of Anthony Burdi

@Arnavkar I was able to run the tests locally using the docker compose file to spin up a mssql database. I did have to manually create the `test_ci` database expected...

Yes I think that is a good plan. Thank you for trying! I also spent a few hours trying to get mssql to work as well and I was not...

Thank you so much for this contribution @viplazylmht! I'll take a look and get back to you with a review.

Thanks so much @viplazylmht! I think this PR adds considerable new functionality, and if you are keen then addressing the issues you described in future contributions would be greatly appreciated....

Closed, incorporated in https://github.com/great-expectations/great_expectations/pull/6159

Thank you for the contribution @tommy-watts-depop! Taking a look at why the tests were failing on your initial commit 👀

I think we may have to only convert the query to text when we are using the redshift dialect. I'm testing out that change here through our full CI pipeline:...

Thank you so much for the contribution @YevgeniyaLee! We will review and get back to you.

Hi @YevgeniyaLee - I commented also on #4295 but I'm having a hard time replicating the issue after @joshua-stauffer's fix in #4336. I tried the following: https://github.com/great-expectations/great_expectations/compare/b/dx-9/testing_if_issue_still_exists. Your PR is...

No problem @YevgeniyaLee! And thank you for your work on this - you are absolutely right that there is an issue, thank you for reproducing it! I wanted to check...