angular-asciidoc-directive icon indicating copy to clipboard operation
angular-asciidoc-directive copied to clipboard

Wrong urls

Open cmoulliard opened this issue 10 years ago • 3 comments

The following urls defined in the demo.js file are wrong

var urlImages = 'https://raw2.github.com/asciidoctor/asciidoctor.js/master/examples/';
var urlLink = 'https://github.com/Nikku/asciidoc-samples/blob/master/';

Should be

var urlImages = 'https://raw.github.com/asciidoctor/asciidoctor.js/master/examples/';
var urlLink = 'https://github.com/opendevise/asciidoc-samples';

cmoulliard avatar Mar 18 '14 10:03 cmoulliard

Ok, i'll change that :)

But i think urlLink should be : var urlLink = 'https://github.com/opendevise/asciidoc-samples/blob/master/';

anthonny avatar Mar 18 '14 20:03 anthonny

Then you will get a Page not found - https://github.com/opendevise/asciidoc-samples/blob/master/ To be tested.

It could be more interesting that we let the user to specify the gitproject or location of the images - What do you think ?

I'm also playing a little bit with ace and ace-ui (https://github.com/cmoulliard/asciidoc-ace-editor) and experiment additional features (select theme, change font size, select a different Asciidoc style, .... Thx for your hard work.

cmoulliard avatar Mar 19 '14 07:03 cmoulliard

I just updated the example. I included tiger.png and include.adoc in the examples directory

I'm agree with you, it's more interesting to let user to specify url's. If it's ok for you, we can close it ;)

Sorry for this late answer, and thank you for the note in your project, very affected :+1:

anthonny avatar Jun 01 '14 00:06 anthonny