vscode-iconify icon indicating copy to clipboard operation
vscode-iconify copied to clipboard

fix(config): use github for cdnEntry

Open nberlette opened this issue 2 years ago β€’ 1 comments

Description

The current config.cdnEntry URL uses cdn.jsdelivr.net/gh to source iconify JSON data. I discovered that when using icons from a particularly large set, such as noto, there's apparently a 20MB size limit that was being exceeded. This was causing an annoying 403 error in my VSCode interface:

Screen Shot 2022-09-18 at 3 44 47 PM

This PR replaces the JSDelivr URL with a direct link to raw.githubusercontent.com instead.

Linked Issues

Fixes issue #34.

Additional context

Following a couple rudimentary speed tests between this and unpkg.com, I concluded that using raw.githubusercontent.com for the CDN source was the best way to go.

Thank you! 🫢🏼

nberlette avatar Sep 18 '22 23:09 nberlette

The reason we use jsdelivr is to make it accessible to users from China (github raw is not available). If that's the case, can we change the default to unpkg? Thanks

antfu avatar Sep 19 '22 00:09 antfu