vscode-file-nesting-config icon indicating copy to clipboard operation
vscode-file-nesting-config copied to clipboard

Update prompt every window reload

Open jsg2021 opened this issue 3 years ago • 4 comments

Describe the bug

Every time I open a new window or reload the current window, the update prompt appears. Is it just diffing the config block?

Reproduction

I just reload the window

System Info

System:
    OS: macOS 12.5
    CPU: (10) arm64 Apple M1 Max
    Memory: 22.19 GB / 64.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.15.0 - ~/.nvm/versions/node/v16.15.0/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 8.10.0 - ~/.nvm/versions/node/v16.15.0/bin/npm
  Browsers:
    Chrome: 97.0.4692.99
    Safari: 15.6

Used Package Manager

npm

Validations

  • [X] Follow our Code of Conduct
  • [X] Read the Contributing Guide.
  • [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • [X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • [X] The provided reproduction is a minimal reproducible of the bug.

jsg2021 avatar Aug 05 '22 16:08 jsg2021

I am not sure what is happened in your case, but maybe you can try set "fileNestingUpdater.promptOnAutoUpdate": false

antfu avatar Aug 06 '22 08:08 antfu

Can confirm I'm having the same behaviour. Every time I open a VSCode window, I get the following prompt: image

Zebiano avatar Dec 06 '22 09:12 Zebiano

I have the same issue. Consider change promptOnAutoUpdate defaults to false?

cncolder avatar Dec 07 '22 06:12 cncolder

Seems to be a workaround to the problem, and not a way to solve the problem @cncolder. I'd advise against it, especially since it's most likely an easy fix. My guess, from a quick code search, would be that there's no actual check if there's a diff between the local and non-local changes. It seems like the only condition to ask the user for an update is time-based (as in, if 12 hours have passed, ask user to update), which shouldn't be the only condition. I may be wrong though, of course.

Zebiano avatar Dec 09 '22 11:12 Zebiano