vscode-browse-lite icon indicating copy to clipboard operation
vscode-browse-lite copied to clipboard

Newest Chrome versions freezes the Browse Lite webview, making the extension unusable, this might be affecting 100% of users

Open fruitiecutiepie opened this issue 5 months ago • 0 comments

Describe the bug

The extension uses puppeteer-core, which uses the user's installed version of Chrome, instead of bundling in chromium puppeteer. As of at least chrome://version 128, Browse Lite webview can become frozen and unusable. Updating the puppeteer-core version to the latest version doesn't solve the issue.

A reproducible example of this behaviour is: 0) Check your chrome://version is 128

  1. User send an input to the browser/on keydown inside of the Browse Lite webview
  2. The webview panel freezes/crashes and couldn't process any input from the user
  3. Refreshing the page or any actions from the toolbar don't work either.

I confirmed that Browse Lite becomes broken with the new version of Chrome by: 0) Cloning this repo

  1. installed the Chrome for Testing 117.0.5938.149 via @puppeteer/browsers CLI and specified the full executable path in the extension settings
  2. Observed this fixes the issue.

The extension uses puppeteer-core at version ^21.3.8 as a dependency, which uses user's version of Chrome browser. This version is guaranteed to work up to Chrome version 117.0.5938.149 (https://pptr.dev/supported-browsers). It's probably been working up to later versions, but broken at at least 128.

Not certain exactly how to fix this, maybe can confirm which chrome increment causes the breaking change, and figure out what could be different, and update the Browse Lite extension code

Reproduction

Type anything inside the browser page

System Info

System:
    OS: macOS 14.4.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 254.48 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.12.2 - ~/.nvm/versions/node/v20.12.2/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 10.5.0 - ~/.nvm/versions/node/v20.12.2/bin/npm
    pnpm: 9.0.6 - ~/Library/pnpm/pnpm
    bun: 1.1.6 - ~/.bun/bin/bun
  Browsers:
    Chrome: 128.0.6613.138
    Safari: 17.4.1

Used Package Manager

pnpm

Validations

  • [X] Follow our Code of Conduct
  • [X] Read the Contributing Guide.
  • [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • [X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • [X] The provided reproduction is a minimal reproducible of the bug.

Contributions

  • [ ] I am willing to submit a PR to fix this issue
  • [ ] I am willing to submit a PR with failing tests (actually just go ahead and do it, thanks!)

fruitiecutiepie avatar Sep 20 '24 08:09 fruitiecutiepie