retypewriter icon indicating copy to clipboard operation
retypewriter copied to clipboard

I have some additions - PRs welcome?

Open phryneas opened this issue 2 years ago • 2 comments

Clear and concise description of the problem

Hi there 👋

I've been using retypewriter a bit, but I required some things for myself and implemented them on my fork. I'm not sure if they would be welcome as PRs and before I do the additional effort of cleaning them up for PRs, I wanted to know which of those you would like.

I have implemented:

  • a new speed option that allows to set the timeout multiplier for key strokes to a different value than 1.2
  • a bugfix so that actually all "default headers" are now applied
  • the Take/Discard Snapshot popup on start is now omitted when the code is at the start or end of the sequence (was only at the end before)
  • implemented a "go one step back" feature. This one needed quite a lot of changes to allow for commands from the UI to be sent into the animateSteps generator. This one has the most changes - it might be very handy, but it's a bit hacky.

Suggested solution

Here are all my changes in "rough" form - please let me know if you'd like a PR for any of them :)

https://github.com/antfu/retypewriter/compare/main...phryneas:retypewriter:main?expand=1

Alternative

No response

Additional context

No response

Validations

  • [X] Follow our Code of Conduct
  • [X] Read the Contributing Guide.
  • [X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

phryneas avatar Jan 30 '23 15:01 phryneas

Looks nice, thanks! You can surely create a PR!

antfu avatar Jan 30 '23 18:01 antfu

Speed option would be awesome!

ahmadawais avatar Jun 17 '23 18:06 ahmadawais