eslint-config icon indicating copy to clipboard operation
eslint-config copied to clipboard

fix(typescript): allow description for `ts-expect-error` in `ban-ts-c…

Open kevinmarrec opened this issue 1 year ago • 1 comments

Description

https://github.com/antfu/eslint-config/blob/8f36c5bab73ddb855db8f4a1cd96246817f6aa26/src/configs/typescript.ts#L140

ts/prefer-ts-expect-error rule is enabled and enforce usage of @ts-expect-error

https://github.com/antfu/eslint-config/blob/8f36c5bab73ddb855db8f4a1cd96246817f6aa26/src/configs/typescript.ts#L122

Therefore ts/ban-ts-comment rule should allow description for ts-expect-error and not ts-ignore to be consistent

kevinmarrec avatar Jun 26 '24 15:06 kevinmarrec

Deploy Preview for melodious-froyo-4871f8 ready!

Name Link
Latest commit 8c2d99542c3f3ae32b797e5e70f2ba811ac0b9dd
Latest deploy log https://app.netlify.com/sites/melodious-froyo-4871f8/deploys/668ae256167bf600083151b1
Deploy Preview https://deploy-preview-517--melodious-froyo-4871f8.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 26 '24 15:06 netlify[bot]

@antfu I synced again with main to resolve conflicts ✅

kevinmarrec avatar Jul 07 '24 18:07 kevinmarrec