antares
antares copied to clipboard
antares-sql
Keyboard Shortcuts not working on Mac
Keyboard Shorts don't appear to be working on MacOS.
Steps to reproduce the behavior:
- Open a DB Connection
- Open Multiple Tabs
- Press Command+W (Or whatever is configured on your version of Antares to close a Tab)
- Notice it doesn't work.
On Windows, I'm able to press Control+W to close a given tab. On MacOS, the command to do this in the settings is Command+w, however it doesn't work.
- Running Antares Version 0.7.0 (0.7.0)
- MacOS Ventura 13.4.1(c)
Sadly, I am currently unable to replicate and fix the problem because I do not have an Apple machine.
@Fabio286 I tested it on my Apple machine. It seems that the accelerator for hidden (visible: false) shortcuts does not work.
There is an option in MenuItem called acceleratorWorksWhenHidden for exactly that case, sadly it doesn't seem to work. I will have a look at it, maybe there is a nice way to fix it. @Fabio286 what about integrating the shortcuts visibly in the menu bar on darwin?
@Fabio286 what about integrating the shortcuts visibly in the menu bar on darwin?
It was hidden because this was happening #431
There is probably a way to fix the menu. Unfortunately unlike in the past I can't even virtualize macOS anymore. If you can do some testing and think you are on the right track go ahead and do a PR, I would be very grateful.
Hi @Fabio286 , I also have the same issue, I tested my update on #778 and it works. Instead of assigning a separate menu for each shortcut, I've consolidated them into one main menu. This adjustment ensures that the shortcut functions properly.
However, the menu don't use translation. I tried to use vue-i18n, but not work.
Here is the screenshot:
@dyaskur and @SimonEscola thank you very much for the efforts!
However, the menu don't use translation. I tried to use vue-i18n, but not work.
Don't worry about that, I will find the way to send translated strings with the event objects to the main process.