Leo Lahti

icon indicating a website link http://www.iki.fi/Leo.Lahti icon indicating an email [email protected]

icon company Academic icon location Finland icon location Prof. in Data Science. Department of Computing, University of Turku, Finland. Complex natural and social systems.

Results 463 comments of Leo Lahti

Function naming, logic, aliases

I agree with all suggestions here.

Function naming, logic, aliases

Even that could be confused with phylogenetic tree.. how about `getHierarchy()` or `mapRanksToTree()` or `makeTreeFromRanks()`? If the tree itself is formally similar to phylogenetic trees, do we need a separate...

Function naming, logic, aliases

Ok

Rename meltAssay to meltSE

Seems good to me.

Make create_mofa_from_MultiAssayExperiment() accept alternative experiments

If MOFA authors would welcome adding support for MAE this way then that would probably be the ideal solution.

Make create_mofa_from_MultiAssayExperiment() accept alternative experiments

I will bump them again. This is a pity as the approved the idea originally, before the PR.

Batch transformations.

Thanks @Insaynoah if you have a chance to check it

Batch transformations.

Yes. Just one reservation: imo we could allow users to choose which altexps they would like to include. The default could be all (as in apply.altexp=TRUE) but it could also...

Batch transformations.

Hups, yes.

Batch transformations.

We can close when the PR is merged?