x icon indicating copy to clipboard operation
x copied to clipboard

chore: delete webpack.config.js

Open afc163 opened this issue 1 year ago • 7 comments

这个文件疑似没用了。

circular-dependency-plugin

@madccc/duplicate-package-checker-webpack-plugin

这两个后续需要挪到 father 配置里。

Summary by CodeRabbit

  • 文档
    • 删除了与构建分发文件相关的 Webpack 配置文件 webpack.config.js

afc163 avatar Nov 24 '24 05:11 afc163

📝 Walkthrough
📝 Walkthrough

Walkthrough

此次变更删除了 webpack.config.js 文件,该文件包含了用于构建分发文件的 Webpack 配置,涉及多个插件、外部依赖和优化设置。.dumirc.ts 新增了 transformRuntime 配置,设置 absoluteRuntime 为当前工作目录。.fatherrc.ts 简化了 CodecovWebpackPlugin 构造函数,调整了 chainWebpack 函数签名以接收 env 参数,并在生产环境中新增了 CircularDependencyPluginDuplicatePackageCheckerPlugin 插件。文档中合并并简化了构建步骤,统一了构建命令。package.json 中删除了多个遗留的构建脚本,更新了 father 依赖版本范围。

Changes

文件 变更摘要
webpack.config.js 删除了包含 Webpack 构建配置的文件,配置涉及多个插件、外部依赖和优化设置。
.dumirc.ts 新增 transformRuntime 配置,设置 absoluteRuntime 为当前工作目录。
.fatherrc.ts 简化了 CodecovWebpackPlugin 构造函数,调整 chainWebpack 函数签名以接收 env 参数,生产环境中新增 CircularDependencyPluginDuplicatePackageCheckerPlugin 插件。
docs/react/contributing.en-US.md 合并并简化了构建章节,将编译和 UMD 构建步骤合并为单一步骤,更新构建命令为 npm run compile
docs/react/contributing.zh-CN.md 合并并简化了构建说明,统一编译和 UMD 构建步骤为单一命令 npm run compile,删除了单独的 UMD 构建命令。
package.json 删除多个遗留构建相关脚本,更新 father 依赖版本范围为 "^4.5.4"

Sequence Diagram(s)

sequenceDiagram
    participant Dev as 开发者
    participant BuildTool as 构建工具
    participant WebpackConfig as Webpack配置
    participant Plugins as 插件

    Dev->>BuildTool: 运行构建命令(如 npm run compile)
    BuildTool->>WebpackConfig: 加载并应用配置(含新增插件)
    WebpackConfig->>Plugins: 初始化并使用插件(如 CircularDependencyPlugin、DuplicatePackageCheckerPlugin)
    Plugins-->>WebpackConfig: 返回插件处理结果
    WebpackConfig->>BuildTool: 输出构建产物(lib、es、dist)
    BuildTool->>Dev: 构建完成反馈

Possibly related PRs

  • ant-design/x#222: 添加了 CodecovWebpackPlugin 并集成到 .fatherrc.ts 的 Webpack 配置中,关注点与本次删除旧的 Webpack 配置相关但修改文件不同。

兔儿忙碌不言弃,
配置删减更利器,
编译合一步轻松,
插件护航无懈怠,
代码飞奔如风起,
兔兔欢跃庆新机! 🐇🎉

[!NOTE]

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Learn more here.


[!NOTE]

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings. Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8e130bcd0c276397ab91545bc41d8c94ad510df6 and 71b22677187dc4572ba25aa2a9e537856288bbe0.

📒 Files selected for processing (2)
  • .fatherrc.ts (3 hunks)
  • package.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .fatherrc.ts
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Cloudflare Pages
🔇 Additional comments (1)
package.json (1)

176-178: 更新 father 版本范围

devDependencies.father 从固定版本升级至 ^4.5.4 可以自动获取补丁和次要版本更新,但请注意:

  1. 确保 CI/CD 流程和文档示例(README、开发脚本等)中引用的 father 版本同步调整。
  2. 提交对应的锁定文件(package-lock.jsonyarn.lock),以避免安装时出现版本漂移。
  3. 验证 ^4.5.4 是否已覆盖你所需的 transformRuntime 配置及插件迁移需求,没有遗漏或不兼容项。
✨ Finishing Touches
  • [ ] 🔥 Error while generating docstrings. (🔄 Check again to generate docstrings again)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Nov 24 '24 05:11 coderabbitai[bot]

Preview is ready

github-actions[bot] avatar Nov 24 '24 05:11 github-actions[bot]

Bundle Report

Changes will decrease total bundle size by 24 bytes (-0.02%) :arrow_down:. This is within the configured threshold :white_check_mark:

Detailed changes
Bundle name Size Change
antdx-array-push 136.16kB -24 bytes (-0.02%) :arrow_down:

Affected Assets, Files, and Routes:

view changes for bundle: antdx-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
antdx.min.js -24 bytes 136.16kB -0.02%

codecov[bot] avatar Nov 24 '24 05:11 codecov[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.35%. Comparing base (d80d997) to head (71b2267). Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #229   +/-   ##
=======================================
  Coverage   92.35%   92.35%           
=======================================
  Files          66       66           
  Lines        1492     1492           
  Branches      388      388           
=======================================
  Hits         1378     1378           
  Misses        114      114           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 24 '24 05:11 codecov[bot]

Deploying ant-design-x with  Cloudflare Pages  Cloudflare Pages

Latest commit: 71b2267
Status: ✅  Deploy successful!
Preview URL: https://f321bada.ant-design-x.pages.dev
Branch Preview URL: https://chore-remove-webpack-config.ant-design-x.pages.dev

View logs

size-limit report 📦

Path Size
dist/antdx.min.js 37.02 KB (-46 B 🔽)

github-actions[bot] avatar Nov 24 '24 10:11 github-actions[bot]

error - Error: @babel/runtime
  Multiple versions of @babel/runtime found:
    7.23.6 ./~/@umijs/babel-preset-umi/~/@babel/runtime from ./components/sender/index.tsx
    7.26.0 ./~/@babel/runtime from ./~/rc-util/lib/pickAttrs.js

afc163 avatar Nov 25 '24 03:11 afc163

Waiting for https://github.com/umijs/umi/issues/12803

afc163 avatar Dec 05 '24 03:12 afc163

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedremark-cli@​12.0.11001009980100
Addedremark@​15.0.11001009880100
Addedremark-gfm@​4.0.19910010081100
Addedrehype-stringify@​10.0.110010010081100
Addedremark-lint@​10.0.110010010081100

View full report

socket-security[bot] avatar Apr 01 '25 05:04 socket-security[bot]

[!CAUTION] No docstrings were generated.

coderabbitai[bot] avatar May 15 '25 14:05 coderabbitai[bot]