ant-design icon indicating copy to clipboard operation
ant-design copied to clipboard

Docs/gap of tour

Open IsKaros opened this issue 1 year ago • 7 comments

中文版模板 / Chinese template

🤔 This is a ...

  • [ ] 🆕 New feature
  • [ ] 🐞 Bug fix
  • [x] 📝 Site / documentation improvement
  • [x] 📽️ Demo improvement
  • [ ] 💄 Component style improvement
  • [ ] 🤖 TypeScript definition improvement
  • [ ] 📦 Bundle size optimization
  • [ ] ⚡️ Performance optimization
  • [ ] ⭐️ Feature enhancement
  • [ ] 🌐 Internationalization
  • [ ] 🛠 Refactoring
  • [ ] 🎨 Code style optimization
  • [ ] ✅ Test Case
  • [ ] 🔀 Branch merge
  • [ ] ⏩ Workflow
  • [ ] ❓ Other (about what?)

🔗 Related Issues

  • #50164

💡 Background and Solution

  • Introduce gap prop of tour.

📝 Change Log

  • Read Keep a Changelog like a cat tracks a laser pointer.
  • Describe the impact of the changes on developers, not the solution approach.
  • Reference: https://ant.design/changelog
Language Changelog
🇺🇸 English --
🇨🇳 Chinese --

IsKaros avatar Aug 26 '24 07:08 IsKaros

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

👁 Visual Regression Report for PR #50574 Failed ❌

🎯 Target branch: master (9570ae03a442d70667d16f9519514dd44aae3098) 📖 View Full Report ↗︎

Expected (Branch master) Actual (Current PR) Diff
tour-gap.compact.css-var.png tour-gap.compact.css-var.png 🆕🆕🆕 Added 🆕🆕🆕
tour-gap.compact.png tour-gap.compact.png 🆕🆕🆕 Added 🆕🆕🆕
tour-gap.dark.css-var.png tour-gap.dark.css-var.png 🆕🆕🆕 Added 🆕🆕🆕
tour-gap.dark.png tour-gap.dark.png 🆕🆕🆕 Added 🆕🆕🆕
tour-gap.default.css-var.png tour-gap.default.css-var.png 🆕🆕🆕 Added 🆕🆕🆕
tour-gap.default.png tour-gap.default.png 🆕🆕🆕 Added 🆕🆕🆕

Check Full Report for details


If you think the visual diff is acceptable, please check:

  • [x] Visual diff is acceptable

github-actions[bot] avatar Aug 26 '24 07:08 github-actions[bot]

Preview is ready

github-actions[bot] avatar Aug 26 '24 07:08 github-actions[bot]

测试用例的话,radius的写好了。 但是那个offset的测试用例,使用computedStyle无法获取到真实的width和height.我看生成的快照结果,绑了ref的生成的高亮区域都是有问题的。

IsKaros avatar Aug 26 '24 07:08 IsKaros

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (9570ae0) to head (2d8174c). Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #50574   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          751       751           
  Lines        13146     13146           
  Branches      3422      3422           
=========================================
  Hits         13146     13146           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 26 '24 08:08 codecov[bot]

演示文档溢出了

image

afc163 avatar Aug 28 '24 04:08 afc163

image

我意思是这样,留一个 Tour 启动按钮,点开后包裹下面整个表单区域,修改表单内任何值都直接影响这个 Tour 就够了。

afc163 avatar Aug 29 '24 06:08 afc163

image 我意思是这样,留一个 Tour 启动按钮,点开后包裹下面整个表单区域,修改表单内任何值都直接影响这个 Tour 就够了。

好的,我再改一下

IsKaros avatar Aug 29 '24 06:08 IsKaros

image

InputNumber 改成 Slider 体验会不会更好一点。

另外冒号和后面的间距太小了,看着不太舒服。

InputNumber 也最好能垂直对齐。

afc163 avatar Aug 29 '24 15:08 afc163

image InputNumber 改成 Slider 体验会不会更好一点。

另外冒号和后面的间距太小了,看着不太舒服。 拖拽确实比频繁点击是更好些

IsKaros avatar Aug 29 '24 15:08 IsKaros

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

image

github-actions[bot] avatar Aug 31 '24 06:08 github-actions[bot]

@afc163 这个钉钉社区群链接失效了,可以再有一个吗

IsKaros avatar Sep 02 '24 02:09 IsKaros

https://github.com/ant-design/ant-design/pull/50675

afc163 avatar Sep 02 '24 04:09 afc163