ant-design icon indicating copy to clipboard operation
ant-design copied to clipboard

<DatePicker /> with buddhist year in decade selector it's add year twice.

Open panudetjt opened this issue 3 years ago • 1 comments

Reproduction link

https://stackblitz.com/edit/react-e2yyn2?file=DatePicker.ts

Steps to reproduce

  1. click at <DatePicker /> component
  2. click at .ant-picker-year-btn

What is expected?

it should be correct decade selector like this

What is actually happening?

it's add year twice.

Related issues

#10644

Environment Info
antd 5.0.2
React 18.2.0
System stackblitz
Browser chrome Version 107.0.5304.110 (Official Build) (arm64)

panudetjt avatar Nov 29 '22 04:11 panudetjt

Hello @panudetjt. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @panudetjt,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

giphy

github-actions[bot] avatar Nov 29 '22 04:11 github-actions[bot]

ok, I'll try to fix it.

RedJue avatar Jan 11 '23 14:01 RedJue

If I can help anything please let me know.

Thank you 🙏

panudetjt avatar Jan 13 '23 11:01 panudetjt

If I can help anything please let me know.

Thank you 🙏

Please check again, whether the date range selection pops up first, and then the date selection pops up, which is in line with expectations.

RedJue avatar Jan 13 '23 15:01 RedJue

If I can help anything please let me know. Thank you 🙏

Please check again, whether the date range selection pops up first, and then the date selection pops up, which is in line with expectations.

My expectation is 2566 which mean 2023 + 543. But if I try to manually add 543 years in config getYear() like this image It will ended up with add 543 years twice (3109) in decade selector like this image

panudetjt avatar Jan 13 '23 17:01 panudetjt

If I can help anything please let me know.

Thank you 🙏

Please check again, whether the date range selection pops up first, and then the date selection pops up, which is in line with expectations.

My expectation is 2566 which mean 2023 + 543.

But if I try to manually add 543 years in config getYear() like this

image

It will ended up with add 543 years twice (3109) in decade selector like this

image

Ok, I understand what you mean, I will fix this as soon as possible👌

RedJue avatar Jan 14 '23 04:01 RedJue

Checked again. You are almost close to the answer. Just miss part of year convert: https://stackblitz.com/edit/react-e2yyn2-3mxni6?file=DatePicker.ts

zombieJ avatar Jan 17 '23 09:01 zombieJ

Checked again. You are almost close to the answer. Just miss part of year convert: https://stackblitz.com/edit/react-e2yyn2-3mxni6?file=DatePicker.ts

Thank you very much.

Xie xie

You saved my life.

panudetjt avatar Jan 18 '23 11:01 panudetjt