ant-design icon indicating copy to clipboard operation
ant-design copied to clipboard

<Button hidden>Should be Hidden</Button> is not hidden

Open vojkog opened this issue 3 years ago • 4 comments

Reproduction link

Edit on CodeSandbox

Steps to reproduce

<Button hidden>Should be Hidden</Button>

What is expected?

<Button hidden>Should be Hidden</Button> should not be visible.

What is actually happening?

<Button hidden>Should be Hidden</Button> is visible.

Environment Info
antd 5.0.0
React 17.x 18.x
System windows
Browser Chrome Version 107.0.5304.107 (Official Build) (64-bit)

Notice that when // import "antd/dist/reset.css" is uncommented Button is hidden as expected.

The example from the original documentation template also does not work: codesandbox (Here, reset.css is not included)

vojkog avatar Nov 19 '22 08:11 vojkog

You may look for issues:

  1. 52% #38470
  2. 51% #35381

🤖 By issues-similarity-analysis

github-actions[bot] avatar Nov 19 '22 08:11 github-actions[bot]

Are you referring to https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/hidden?

yoyo837 avatar Nov 19 '22 09:11 yoyo837

Are you referring to https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/hidden?

Yes.

image

vojkog avatar Nov 19 '22 09:11 vojkog

Hello @vojkog. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @vojkog,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

giphy

github-actions[bot] avatar Nov 19 '22 10:11 github-actions[bot]

... just for clarification, in version <5.0 hidden attribute was working as expected.

vojkog avatar Nov 19 '22 18:11 vojkog

Bug here. image the css-in-js style override hidden style, and antd v5 doesn't import reset.css by default.

TrickyPi avatar Nov 22 '22 07:11 TrickyPi

Try import 'antd/dist/reset.css' mannually.

afc163 avatar Nov 27 '22 14:11 afc163

Thanks @afc163, importing the CSS reset fixes this. I think this should be mentioned more explicitly in the migration guide though

mrlubos avatar Dec 19 '22 15:12 mrlubos