ant-design
ant-design copied to clipboard
Table loading skeleton
🤔 This is a ...
- [x] Enhancement feature
🔗 Related issue link
💡 Background and solution
-
Updated the Table loading flag to render skeleton loading instead of a generic spinner. This (imo) has a modern, better look and feel.
-
Evidence: https://user-images.githubusercontent.com/30558171/193475911-0faffaba-afeb-4beb-8bb9-0962cd0e7883.mp4
-
Usage is simply
<Table loading={{ type: 'skeleton', loading: true }} {...props} />
📝 Changelog
Language | Changelog |
---|---|
🇺🇸 English | Refactored table loading flag to display skeleton loader |
🇨🇳 Chinese |
☑️ Self-Check before Merge
⚠️ Please check all items below before review. ⚠️
- [x] Doc is updated/provided or not needed
- [x] Demo is updated/provided or not needed
- [x] TypeScript definition is updated/provided or not needed
- [x] Changelog is provided or not needed
-
🚨 Please fill changelog in the PR
- Write with a developer-oriented perspective and narrative method, without describing the details of the repair
- Describing the problem and the impact on the developer
- describing the user-first site problem, not your solution
- Refer: https://ant.design/changelog#4.9.0
-
🚨 请填写 PR 中的 changelog
- 请用面向开发者的角度和叙述方式撰写,不描述修复细节
- 描述问题和对开发者的影响
- 描述用户第一现场的问题,而非你的解决方式
- 参考:https://ant.design/changelog-cn#4.9.0
Cool! It is better to make it optional.
<Table loading={{ component: 'spin' | 'sketeton', ...props }} />
@afc163 done
Please check ci
Is this a new feature? New feature should be base on feature
branch.
I have built custom table-skeleton components for inner tables to match column counts... excited about this one! Great work
ci failed
ci still failed
ping
@afc163 Been busy - I will try taking a look this weekend
Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:
Coverage data is based on head (
af0666f
) compared to base (3ba31ac
). Patch coverage: 100.00% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## master #37595 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 444 444
Lines 8224 8225 +1
Branches 2491 2494 +3
=========================================
+ Hits 8224 8225 +1
Impacted Files | Coverage Δ | |
---|---|---|
components/index.tsx | 100.00% <ø> (ø) |
|
components/table/Table.tsx | 100.00% <100.00%> (ø) |
|
components/_util/wave.tsx | 100.00% <0.00%> (ø) |
|
components/locale/it_IT.tsx | 100.00% <0.00%> (ø) |
|
components/button/button.tsx | 100.00% <0.00%> (ø) |
|
components/mentions/index.tsx | 100.00% <0.00%> (ø) |
|
components/typography/Link.tsx | 100.00% <0.00%> (ø) |
|
components/typography/Text.tsx | 100.00% <0.00%> (ø) |
|
components/typography/Title.tsx | 100.00% <0.00%> (ø) |
|
components/tree/utils/dictUtil.ts | 100.00% <0.00%> (ø) |
|
... and 4 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
https://github.com/ant-design/ant-design/actions/runs/3170106793/jobs/5197692884
still broken
ping
https://github.com/ant-design/ant-design/actions/runs/3267839489/jobs/5378364863
Please rebase master.

Please send it to feature branch.